-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sakura term truecolor weirdness #46
Comments
In case any of that matters:
|
The “System Colors“ are the ones provided by the terminal and most terminals provide ways to customize or import these "theme" colors. It looks like the current colors are coming from Solarized (a popular theme shipped with almost every terminal by default). |
@arcticicestudio I get a I shall try to make a theme for Sakura and post it here. |
Urgh. I appears that sakura deals with colour pallets via its source code. They are hard coded. Here is the solarized one, from the source repository
So, it should be easy to modify this to get the Nord theme in. However, I have no time to do it justice. I will try to get tilix working. If anyone else wants to attempt it, I am happy to test/help. |
The Tilix port is still pending the Nord Docs data transition, but the description contains a link to the GitHub repository. Based on your screenshot I guess the problem regarding missing colors is solved so I close this ticket for now |
@arcticicestudio I got it alomost working. However, the cube I use is not correct. I wondering if you could help me here: I need a 16 color palettes where
Do you know where I could find the correct one in the Nord docs? Thank you. |
Sorry, I don't know what you mean 😐 |
😁 Me neither! I am just looking at the comments in the source. Not the best comments I have seen.
Thanks. Will have a look. Could you reopen this and add a "help wanted" tag? Thank you. |
@arcticicestudio From Solarized, what are the Nord corresponding colours to the following?
|
Those colours are wrong! Bah. |
Nord patch to Sakura latest version. Could someone test this please? |
Thanks for creating the upstream bug report 👍 |
@arcticicestudio I have had no news from the developers since I posted this about 22 days ago… Does not look good to be honest. |
Well, you've also posted the link to the report here 22 days ago and I only had time again today to spend on some open source projects to reply here 😄 Anyway, I'll check the upstream issue from time to time and will close it when it seems that Sakura is not actively developed anymore. |
Got a reply! This looks good.
Can you point me to where I can find those? Thank you. |
Nord uses a scheme for the 16 ANSI colors that is a bit different. Instead of using brighter versions of the first 8 colors I've tried to include as many colors from Nord's color palettes as possible, so e.g. color 6 (blue) is |
I guess these colors match fine now 😄 |
@arcticicestudio Could you add Sakura to the list of supported terminals? |
Actually there is no list of supported terminals but official port projects. Since the support for Nord has been patched into Sakura itself this is out-of-scope. There are many projects that added native support for Nord like e.g. OniVim or Bitwarden which is outside the area of responsibility for me. |
No worries. As long as there is a note somewhere that sakura supports Nord, that's good enough. Many thanks indeed for your help in getting this resolved. I shall close this now. If you feel there is more to do, please re-open and let me know. |
I tried to get another terminal to fix another bug and got nightly confused. Here is the terminal session with some debugging:
Clearly the last command does not output the right colours and therefore I cannot use the Nord theme -- or at least, no how it is intended.
What am I doing wrong?
The text was updated successfully, but these errors were encountered: