Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme does not set Terminal highlight group #325

Open
ntessore opened this issue Sep 21, 2022 · 3 comments · May be fixed by #337
Open

theme does not set Terminal highlight group #325

ntessore opened this issue Sep 21, 2022 · 3 comments · May be fixed by #337
Labels
context-syntax scope-quality

Comments

@ntessore
Copy link

As far as I can tell, the theme does not set the Terminal highlight group, which for me means a :terminal window has default foreground and background colours.

I would expect something like this does the trick:

"+- Vim 8 Terminal Colors -+
if has('terminal')
  let g:terminal_ansi_colors = [...]
  call s:hi("Terminal", ...)
endif

Relevant part of :h terminal-size-color:

To use a different color the Terminal highlight group can be used, for example:
hi Terminal ctermbg=lightgrey ctermfg=blue guibg=lightgrey guifg=blue
@Freedzone
Copy link

I believe linking to Normal group should be good enough
highlight! link Terminal Normal
Before certain version Vim was doing this by default. But suddenly the terminal became black and white.

vds2212 added a commit to vds2212/nordtheme-vim that referenced this issue Mar 21, 2023
@vds2212
theme does not set Terminal highlight group nordtheme#325
bb78c58
@vds2212 vds2212 linked a pull request Mar 21, 2023 that will close this issue
Open
@svengreb svengreb changed the title theme does not set "Terminal" highlight group theme does not set Terminal highlight group Jun 8, 2023
@svengreb svengreb moved this from triage to queued in Planning & Roadmaps Jun 8, 2023
@svengreb svengreb moved this from queued to review in Planning & Roadmaps Jun 8, 2023
@svengreb
Copy link
Member

svengreb commented Jun 8, 2023

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the backlog in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

@ntessore Thanks again for your contribution! @vds2212 submitted the pull request #337 that will has been added to the backlog for further processing.

@vds2212
Copy link

vds2212 commented Jun 10, 2023

Thank for your nice message. Don't put too much pressing on yourself.

I'm glad to help. Let me know if I can do something for the project.

But I can also just be patient. It is something I can also do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax scope-quality
Projects
Planning & Roadmaps
Status: review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theme does not set Terminal highlight group vds2212/nordtheme-vim
4 participants
@vds2212 @ntessore @Freedzone @svengreb