Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown blockquote text is too dark #72

Closed
nathonius opened this issue Jun 4, 2018 · 2 comments
Closed

Markdown blockquote text is too dark #72

nathonius opened this issue Jun 4, 2018 · 2 comments

Comments

@nathonius
Copy link

nathonius commented Jun 4, 2018

Perhaps not constrasting enough is a more accurate description. A better color should be selected. Perhaps to differentiate it from other text, it could be made italic? For now I've just set it to the same color as my comments, which I have at #66738e.

capture70

This is text.html.markdown markup.quote.

@arcticicestudio
Copy link
Contributor

Thanks for your contribution 👍

This is related to #14 and the resulting nordtheme/nord#94 . When both issues have been resolved/implemented this will also be applied to quotes in Markdown since these are a main element of the Markdown syntax. You can use a scoped customization like described by a user in #14.

@arcticicestudio arcticicestudio modified the milestone: 0.7.0 Jun 26, 2018
@arcticicestudio arcticicestudio added this to the 0.8.0 milestone Apr 11, 2019
@arcticicestudio
Copy link
Contributor

Hi @OfficerHalf 👋 again

Its finally time to close this long-time issue 🎉

PR #118 (implementing nordtheme/nord#94 through #117) has been merged and version 0.8.0 has been release and deployed to the VS Code Marketplace 🚀

The comment's color brightness (nord3) is now increased by 10% from a lightness level of ~35% to ~45%.

Feel free to let me know what you think about this change!
➜ Please see nordtheme/nord#94 for all details about this design change decision.

Before

gh-146-before
gh-145-before-2

After

gh-146-preview
gh-145-preview-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants