Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Introduce Ruff #919

Closed
ogenstad opened this issue Jun 10, 2024 · 5 comments
Closed

Suggestion: Introduce Ruff #919

ogenstad opened this issue Jun 10, 2024 · 5 comments

Comments

@ogenstad
Copy link
Collaborator

Introduce Ruff and have it replace:

  • Black
  • isort
  • pylama

While Ruff also has checks for type annotations the recommendation is still to keep using mypy.

Thoughts around this @dbarrosop & @ktbyers?

@dbarrosop
Copy link
Contributor

I have no opinion, as long as it covers the same functionality (or even more) than the ones being replaced I am good. The formatter is the only thing that I am not sure about. Is it as extremely opinionated as black? I may not always agree with black but I like that I (or anyone else) have no choice other than to abide by it :)

@ogenstad
Copy link
Collaborator Author

Ruff will have more functionality, it's pretty much as opinionated as Black (https://docs.astral.sh/ruff/formatter/#black-compatibility), there are some slight changes depending on the codebase there could be a small number of lines that change during the migration.

I think it's nice as it's fewer tools to deal with, it's also faster though that doesn't have much of an impact on this codebase.

@ktbyers
Copy link
Collaborator

ktbyers commented Jun 10, 2024

I am fine either way on this.

@dbarrosop
Copy link
Contributor

Yeah, I am good with the change too.

@ogenstad
Copy link
Collaborator Author

Fixed in #926 and #930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants