Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL support using YesSQL #4

Open
SebastianStehle opened this issue Dec 21, 2020 · 8 comments
Open

SQL support using YesSQL #4

SebastianStehle opened this issue Dec 21, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SebastianStehle
Copy link
Collaborator

No description provided.

@SebastianStehle SebastianStehle added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 21, 2020
@faridprogrammer
Copy link

faridprogrammer commented Dec 23, 2020

Hello.
I can do this.
Let me check the project source code out.

@SebastianStehle
Copy link
Collaborator Author

Sure, you are welcome. EF is also an option as it is probably needed for identity

@faridprogrammer
Copy link

I have noticed that the project is using the MongoDB scheduling mechanism.
By supporting SQL do we need to completely cut the MongoDB from the project? and need to find an alternative solution for the scheduling part?
or we can use both MongoDB and SQLServer at the same time?

@SebastianStehle
Copy link
Collaborator Author

The MongoDB scheduler is basically a timer: https://github.com/notifo-io/notifo/blob/main/backend/src/Notifo.Infrastructure/MongoDb/Scheduling/MongoDbScheduler.cs

I can make the timer part reusable, then we only need to rebuild the store part for SQL.

@SebastianStehle
Copy link
Collaborator Author

I have decoupled the timer stuff from MongoDB.

@faridprogrammer
Copy link

Thanks.

@faridprogrammer
Copy link

Should I remove the MongoDB implementations or keep them?

@SebastianStehle
Copy link
Collaborator Author

No, I need them ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants