Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing identifier Field in LayoutDto for Novu Python SDK #295

Open
Alleny244 opened this issue Jun 19, 2024 · 0 comments
Open

Missing identifier Field in LayoutDto for Novu Python SDK #295

Alleny244 opened this issue Jun 19, 2024 · 0 comments

Comments

@Alleny244
Copy link
Contributor

Alleny244 commented Jun 19, 2024

Describe the bug

I'm encountering an issue with the Novu Python SDK while trying to create a layout. The API returns a 400 Bad Request error with the message indicating that the identifier should not be null or undefined and must be a string. However, the LayoutDto class in the SDK does not provide an option to pass the identifier, which seems to be required by the API.

Error Message

requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.novu.co/v1/layouts {'message': ['identifier should not be null or undefined', 'identifier must be a string'], 'error': 'Bad Request', 'statusCode': 400}

To Reproduce

  1. Create a LayoutDto instance without an identifier field.
  2. Attempt to create a layout using the Novu Python SDK.
  3. Observe the 400 Bad Request error.

Expected behavior

The layout should be created successfully without a 400 Bad Request error.

Screenshots

The API returns a 400 Bad Request error indicating that the identifier field is missing.
Screenshot 2024-06-19 at 4 57 00 PM

Versions

  • Novu version: Novu SaaS
  • Python version: 3.12.3
  • Novu-python version: 1.14.0

Additional context
I have added a fix for the same
Pull request for the fix : pull-294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant