Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Methods for Notification templates #69

Open
Cliftonz opened this issue Oct 2, 2023 · 6 comments
Open

Add Missing Methods for Notification templates #69

Cliftonz opened this issue Oct 2, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Cliftonz
Copy link

Cliftonz commented Oct 2, 2023

Some endpoints of the following section can't be hit from this SDK.

We would like to ensure that all endpoints can be hit. For this issue, we would like to build out the Notification templates

Some of these methods may already exist. 
If so no need to change/update them, just point out that they already exist and we will close the issue.

This is just to bring every SDK we have on par with all the methods available.

Check all the endpoints here and add the missing ones.

@Cliftonz Cliftonz added the enhancement New feature or request label Oct 2, 2023
@FazleRabbbiferdaus172
Copy link

Hi Cliftonz, swagger shows that endpoints under notification templates have been renamed to Workflows. Under Workflows there are 6 endpoints and all of them are implemented under NotificationTemplateApi. Trying out all 6 endpoints either responses with 401 or 403.

@unicodeveloper
Copy link
Contributor

@FazleRabbbiferdaus172 where are you trying out the endpoints?

@FazleRabbbiferdaus172
Copy link

@unicodeveloper Swagger link is provided in the issue description, I tried out the endpoints under the Workflow section.

@unicodeveloper
Copy link
Contributor

Can you try them out in the api reference doc? https://docs.novu.co/api-reference/workflows/get-workflows
@FazleRabbbiferdaus172

Add your API key so you can get the results.

CleanShot 2023-10-04 at 08 37 45

@FazleRabbbiferdaus172
Copy link

@unicodeveloper Tried them out in api reference doc, Get workflows endpoint responses in 200. But do the reference docs endpoints ensure that the python sdk wroks?

@unicodeveloper
Copy link
Contributor

@FazleRabbbiferdaus172 I am not sure if i get you correctly. But you can always use the reference docs to test any of the endpoints quickly. It's independent of the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants