Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ShopifySharp.GraphQL pre-generated classes to use the IJsonSerializer interface where possible #1136

Open
nozzlegear opened this issue Jan 21, 2025 · 0 comments
Labels
enhancement serialization Anything affecting json or http content serialization.

Comments

@nozzlegear
Copy link
Owner

nozzlegear commented Jan 21, 2025

Right now the generated classes in ShopifySharp.GraphQL all have extension methods for serializing and deserializing themselves using System.Text.Json. I'd like to explore whether it's possible to refactor (or disable?) those extension methods to use ShopifySharp's new IJsonSerializer interface, which is built for DI and to let devs choose which serialization library is used with the GraphService (e.g. Newtonsoft, System.Text.Json, etc.).

@nozzlegear nozzlegear converted this from a draft issue Jan 21, 2025
@nozzlegear nozzlegear added enhancement serialization Anything affecting json or http content serialization. labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement serialization Anything affecting json or http content serialization.
Development

No branches or pull requests

1 participant