Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2.0.0 #34

Merged
merged 1 commit into from
Aug 13, 2024
Merged

chore: release 2.0.0 #34

merged 1 commit into from
Aug 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 6, 2024

🤖 I have created a release beep boop

2.0.0 (2024-08-07)

⚠️ BREAKING CHANGES

Features

Bug Fixes

Documentation

Chores


This PR was generated with Release Please. See documentation.

Copy link
Contributor Author

github-actions bot commented May 6, 2024

Release Manager

Release workflow run: https://github.com/npm/types/actions/runs/10287069984

Release Checklist for v2.0.0

  • 1. Approve this PR

    gh pr review 34 -R npm/types --approve
  • 2. Merge release PR 🚨 Merging this will auto publish 🚨

    gh pr merge 34 -R npm/types --squash
  • 3. Check For Release Tags

    Release Please will run on the just pushed release commit and create GitHub releases and tags for each package.

    gh run watch -R npm/types $(gh run list -R npm/types -w release -b main -L 1 --json databaseId -q ".[0].databaseId")

@github-actions github-actions bot force-pushed the release-please--branches--main branch 13 times, most recently from 276f060 to 247996b Compare May 8, 2024 21:37
@broofa
Copy link
Contributor

broofa commented Jun 24, 2024

@lukekarrys Any word on when this will be published?

@Jjmace7 Jjmace7 mentioned this pull request Jul 1, 2024
1 task
@lukekarrys
Copy link
Contributor

@broofa I'm no longer a member of the npm team so I won't be able to publish this. Hopefully someone on @npm/cli-team can help out.

@broofa
Copy link
Contributor

broofa commented Jul 17, 2024

@lukekarrys : Any idea who, specifically, I can ping about this? This is so close. Literally all that's left is for someone to click the damn "merge" button, no?

My unprofessional reaction aside, thanks for all your work on this. Hopefully you've moved on to something newer and interesting-er!

@broofa
Copy link
Contributor

broofa commented Jul 19, 2024

@GrantBirki @arisacoba @dhei @dylanatsmith @feelepxyz @joseph-lozano @joshspicer @jumoel @leobalter @monishcm @mrecachinas @MylesBorins @navin22 @nishantms @pwelch @reggi @saquibkhan @shmam @steiza @strackoverflow @Tayvon @tiagonbotelho @trevrosen @vcsjones @wraithgar @xodene

My sincere apologies for the "@"-spam here, but this situation is a bit frustrating. Briefly...

  • I've been working with @lukekarrys to bring much-needed updates to this project. This has involved a non-trivial amount of work that, personally, I'm pretty proud of. It is a tangible improvement that many people in the community should find useful. This was completed and merged 2+ months ago in feat!: 2024 updates, maintainer handoff proposal #29.
  • That work should have been released as @npm/[email protected] (this PR)... but for whatever reason that never happened.
  • And now, with @lukekarrys moving on it's unclear who, if anybody, is in a position to actually move this PR forward.

So my immediate ask is this: Please help me identify someone who can merge and publish this PR

If that happens to be one of you folks...

That's it. That's all I need.

Again, my apologies for the spam.

@reggi reggi self-assigned this Jul 19, 2024
@leobalter
Copy link

Hi @broofa you might have missed including me on the cc list.

I'm coordinating with the npm team how we best continue here both on the release and the follow up changes you mentioned.

While I'm writing this, it seems @reggi is already self assigning here and so I'm optimistic to see this resolved soon!

@lukekarrys
Copy link
Contributor

There was one technical hang-up on getting this published, which is why I wasn't able to merge this PR previously.

@reggi Even though the Release Manager issue says otherwise, merging this PR won't actually publish it since I never got around to creating a publish token for @npm/types. There was concern that the @npm scope was not the correct place to publish this anymore since that scope is mostly reserved for internal packages. I thought about changing it to @npm-cli but then the name would be @npm-cli/types which would be pretty confusing imo.

This is just to give context around why it hasn't been published yet. The solution will be to create a publish token for whatever the name ends up being (even if it stays as @npm/types) and adding it as a repo secret and then merging this PR.

@github-actions github-actions bot force-pushed the release-please--branches--main branch 2 times, most recently from 1fbd8bf to 981e1a0 Compare July 24, 2024 20:59
@github-actions github-actions bot force-pushed the release-please--branches--main branch 3 times, most recently from 1619f18 to 98a2b75 Compare August 7, 2024 15:17
@github-actions github-actions bot force-pushed the release-please--branches--main branch from 98a2b75 to f335748 Compare August 7, 2024 15:18
@reggi reggi merged commit 19fdbfb into main Aug 13, 2024
4 checks passed
@reggi reggi deleted the release-please--branches--main branch August 13, 2024 16:30
Copy link
Contributor Author

🤖 Release is at https://github.com/npm/types/releases/tag/v2.0.0 🌻

Copy link
Contributor Author

github-actions bot commented Aug 13, 2024

Release Workflow

🚨🚨🚨

@npm/cli-team: The post-release workflow failed for this release. Manual steps may need to be taken after examining the workflow output.

🚨🚨🚨

@broofa
Copy link
Contributor

broofa commented Aug 13, 2024

It looks like 2.0.0 is up on NPM. Huzzah! Thanks for making this happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants