samples: matter: Added DSLS support to the smoke co alarm #19151
+599
−470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 757f7272bc1b1a5c02b9246ce0d1d90334ab2ce6 more detailssdk-nrf:
matter:
Github labels
List of changed files detected by CI (11)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
kkasperczyk-no
force-pushed
the
icd_dsls_support
branch
from
1b0802b
to
92753da
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
peknis
requested changes
Nov 29, 2024
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
Comment on lines
158
to
167
| * - Power source on | ||
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | ||
| - Trigger an action that changes power source state to active | ||
| - ``0xFFFFFFFF80000000`` - ``0xFFFFFFFF80000001`` | ||
| - The range of ``0x0`` - ``0x1`` is the endpoint id that has power source cluster instance enabled. | ||
| * - Power source off | ||
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | ||
| - Trigger an action that changes power source state to unavailable | ||
| - ``0xFFFFFFFF80010000`` - ``0xFFFFFFFF80010001`` | ||
| - The range of ``0x0`` - ``0x1`` is the endpoint id that has power source cluster instance enabled. |
There was a problem hiding this comment.
Suggested change
| * - Power source on | |
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | |
| - Trigger an action that changes power source state to active | |
| - ``0xFFFFFFFF80000000`` - ``0xFFFFFFFF80000001`` | |
| - The range of ``0x0`` - ``0x1`` is the endpoint id that has power source cluster instance enabled. | |
| * - Power source off | |
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | |
| - Trigger an action that changes power source state to unavailable | |
| - ``0xFFFFFFFF80010000`` - ``0xFFFFFFFF80010001`` | |
| - The range of ``0x0`` - ``0x1`` is the endpoint id that has power source cluster instance enabled. | |
| * - Power source on | |
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | |
| - Trigger an action that changes power source state to active. | |
| - ``0xFFFFFFFF80000000`` - ``0xFFFFFFFF80000001`` | |
| - The range of ``0x0`` - ``0x1`` is the endpoint ID that has power source cluster instance enabled. | |
| * - Power source off | |
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | |
| - Trigger an action that changes power source state to unavailable. | |
| - ``0xFFFFFFFF80010000`` - ``0xFFFFFFFF80010001`` | |
| - The range of ``0x0`` - ``0x1`` is the endpoint ID that has power source cluster instance enabled. |
Check the punctuation in the whole table. It is a bit inconsistent here and there.
kkasperczyk-no
force-pushed
the
icd_dsls_support
branch
from
92753da
to
8e6aecd
Compare
nordicjm
approved these changes
Nov 29, 2024
Integrated and enabled ICD DSLS feature with the smoke CO alarm sample. Additionally, added documentation of test event triggers dedicated for switching the power source. Signed-off-by: Kamil Kasperczyk <[email protected]>
kkasperczyk-no
force-pushed
the
icd_dsls_support
branch
from
8e6aecd
to
757f727
Compare
| - Only for :ref:`Matter Smoke CO Alarm <matter_smoke_co_alarm_sample>` | ||
| - Trigger an action that changes power source state to active. | ||
| - ``0xFFFFFFFF80000000`` - ``0xFFFFFFFF80000001`` | ||
| - The range of ``0x0`` - ``0x1`` is the endpoint ID that has power source cluster instance enabled. |
There was a problem hiding this comment.
What about adding a description here that 0x0 is dedicated to "wire powering" and 0x1 to "battery powering"?
| @@ -119,6 +119,11 @@ To configure the LIT, CIP, UAT or DSLS, use the following Kconfig options: | |||
| The DSLS support allows the application to dynamically switch between SIT and LIT modes, as long as the requirements for these modes are met. | |||
| This option is by default disabled for the LIT device. | |||
|
|
|||
| You can enable optional reporting on entering the active mode. | |||
| When enabled, the device sends a data report to the subscribed devices. | |||
| This could be useful especially in the combination with the User Active Mode Trigger (UAT) feature, to inform the subscribed Matter controller that the user triggered an ICD to enter the active mode. | |||
There was a problem hiding this comment.
Shouldn't it be (UAMT)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated and enabled ICD DSLS feature with the smoke CO alarm sample. Additionally, added documentation of test event triggers dedicated for switching the power source.