-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: iNews compatiblity with segments #1126
Comments
Thank you for submitting this RFC! We've done a quick huddle in the Sofie Team, and we'd like to invite you to a workshop where we'll outline a plan for how this could be implemented, on Tuesday, January 23rd at 15:00 CET (14:00 GMT, 9:00 EST). If anyone else wishes to join the workshop, please email me at [email protected] |
Just putting a couple of quick notes here ahead of the workshop.
Then for a given story it's: Where the numbers reflect the internal numbering system of the NCS and the first part of the The The way this translates into Sofie currently is that each story or 'line' in the NCS becomes a separate segment which is our desired behaviour. It would be great to have this configurable as it means the behaviour then could be changed regardless of NCS and could even be changed for different studios if desired. |
Meeting notes, Workshop January 23rdIdeas for how to group storiesThere are several possible ways to group stories into segments in the NCS, some ideas are:
It should be noted that whatever solution we come up with, it should be possible to keep existing behaviour, which includes "no grouping of stories at all". The current data flowIn Sofie, there are two data flows as of today: MOS
Not MOS
Suggested new data flowTo allow for different algorithms for grouping stories, we propose modifying the ingest data flow in Sofie Core by introducing a new blueprint method, responsible for reworking and grouping of The new blueprint method can be optional in the blueprints, with a default behaviour matching today's. MOS
Not MOS
Notes from discussion
|
FYI: Please let me know before spending time on implementing this and I'll help coordinate efforts. |
We have not started implementation, so yes, if it can be part of #1121, it's fine for us. |
I just saw that #1121 is now closed. Have you had the chance to address this issue as well ? Thanks ! |
The PR for #1121 is currently awaiting review and merging #1293 But yes, it puts some pieces in place to allow you to do this. The relevant portion of the change is that the grouping of MOS stories into segments is now handled by the new If not implemented, the default implementation of this method looks like:
which retains backwards compatibility. For your case, you would need to implement this new
Something would need to be filled in where the TODO is, depending on the workflow you want in inews. |
Pretty neat! I will probably wait after the code review to test it in release52. Thanks for the detailed explanations! |
About me
This RFC is posted on behalf of CBC/Radio-Canada
Use case
In ENPS, it's possible to group multiple stories together to form a segment. The MOS Gateway sends the stories to Sofie with a slug value with the format "SEGMENT NAME; STORY NAME". The Sofie Core then merges the stories together to form the segments and keeps track of the changes coming from ENPS.
In iNews, there is no such thing as a « segment ». We can force individual story slugs to use the format "SEGMENT NAME; STORY NAME", but that means we have to duplicate the segment name in each story. There is no way to assign a single value to multiple stories.
So the two challenges are : first, how can we define a segment coming from iNews and second, how can we name it using a single value in one of the stories of the segment ?
Proposal
I've noticed that Sofie uses the "SEGMENT NAME;" to name the segment, but the segment grouping is not entirely done using the segment name as an id. For example, two groups of stories separated by an empty story will form two segments in the rundown, even if they use the same segment id.
This is a great behavior, and that means there is already a notion of « separator », an empty story being the separator in that case. So one way of creating a segment would be to use an empty story as a separator, even for stories with no segment name like the one coming in from iNews. One step further would be to define in the blueprint which characters in the slug should identify the story acting as a separator. For example, the separator could be a story with an empty slug "" or with the slug characters "=====================".
As for the naming of the segment, we coud define in the blueprint a pattern to extract the name from the story slugs. For exemple, we could define a start character "[" and an end character "]" so if the string "[SEGMENT 1]" is found in one of the story slugs of the segment, it will be identified and parsed as the segment name "SEGMENT 1".
There are probably a lot of ways to do that, so I'm open to suggestions !
Process
The Sofie Team will evaluate this RFC and open up a discussion about it, usually within a week.
The text was updated successfully, but these errors were encountered: