Add clear filters from within big filter

[LorenzoSapora]

Hey, great package. Feature suggestion: Adding the 'clear filter' button to the big filter.

Here's the codeblock from the default component.

                <div v-if="filtersAreApplied" class="bg-30 border-b border-60">
                    <button
                        @click="$emit('clear-selected-filters')"
                        class="py-2 w-full block text-xs uppercase tracking-wide text-center text-80 dim font-bold focus:outline-none"
                    >
                        {{ __('Reset Filters') }}
                    </button>
                </div>

I'm not 100% up on my vue lang, but I assume this is all that's needed, if you're extending the existing filter (with a few css class tweaks).

[LorenzoSapora]

Hmm. I was just looking around, to see if I could push a PR for this issue, and it appears you've already started on this

In resources/js/components/Card.vue

            <!--<div v-if="filtersAreApplied" class="bg-30 border-b border-60">-->
            <!--<button-->
            <!--@click="$emit('clear-selected-filters')"-->
            <!--class="py-2 w-full block text-xs uppercase tracking-wide text-center text-80 dim font-bold focus:outline-none"-->
            <!--&gt;-->
            <!--{{ __('Reset Filters') }}-->
            <!--</button>-->
            <!--</div>-->

[jerrychee94]

Lorenzo, unfortunately $emit('clear-selected-filters') in FilterMenu.vue(default filter from laravel nova) is emitting event to Index.vue (default index from laravel nova) and it will trigger clearSelectedFilters method from laravel packages. I found a solution for this and I hope to include it in the PR.

[LorenzoSapora]

Excellent, look forward to seeing the PR

[jerrychee94]

Here you go. I've added a PR but I'm not sure it's right way to make a PR or not. It's my first ever PR on GitHub. #18

[edanisko]

Hello Jerry, I will work on this late Thursday and Friday. I appreciate the help. Thank you, Ed Ed Anisko

…

________________________________ From: Jerry Chee <[email protected]> Sent: Wednesday, November 27, 2019 7:49:54 AM To: nrml-co/nova-big-filter <[email protected]> Cc: Subscribed <[email protected]> Subject: Re: [nrml-co/nova-big-filter] Add clear filters from within big filter (#10) Here you go. I've added a PR but I'm not sure it's right way to make a PR or not. It's my first ever PR on GitHub. #18<#18> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#10?email_source=notifications&email_token=AAHHKLUXMSTOT74G7F25XR3QV2JKFA5CNFSM4I5BAHNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJ5XHA#issuecomment-559143836>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHHKLQ6MVZDMVALXITDXTDQV2JKFANCNFSM4I5BAHNA>.

[jerrychee94]

Hi @edanisko,

Appreciate your attention here. Hope this fix will help :)

Jerry Chee

[flatcapco]

Is this possible to merge? @edanisko

Thank you