From 7f4fc50dfb21b2aaa8683fde549191b8cda8000b Mon Sep 17 00:00:00 2001
From: Jason Jean <jasonjean1993@gmail.com>
Date: Wed, 13 Nov 2024 11:53:59 -0500
Subject: [PATCH] =?UTF-8?q?fix(core):=20create=20different=20dummy=20tasks?=
 =?UTF-8?q?=20for=20different=20parent=20tasks=20an=E2=80=A6=20(#28923)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

…d dependency targets

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Dummy tasks are given an ID containing the parent task's target.
Multiple parent tasks can create the same dummy task which overrides
other dummy tasks.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Dummy tasks are given an ID containing the dependency and the parent
tasks's name. This means different parent tasks will create different
dummy tasks instead of overriding other ones.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
---
 packages/nx/src/tasks-runner/create-task-graph.ts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/nx/src/tasks-runner/create-task-graph.ts b/packages/nx/src/tasks-runner/create-task-graph.ts
index 6ad8fb58801e6..bb97f6e06eff1 100644
--- a/packages/nx/src/tasks-runner/create-task-graph.ts
+++ b/packages/nx/src/tasks-runner/create-task-graph.ts
@@ -287,9 +287,13 @@ export class ProcessTasks {
           );
         }
       } else {
+        // Create a dummy task for task.target.project... which simulates if depProject had dependencyConfig.target
         const dummyId = this.getId(
           depProject.name,
-          task.target.target + DUMMY_TASK_TARGET,
+          task.target.project +
+            '__' +
+            dependencyConfig.target +
+            DUMMY_TASK_TARGET,
           undefined
         );
         this.dependencies[task.id].push(dummyId);