Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Checkstyle rule in Checkstyle.xml and Apply New Changes to HIRS_UTILS #864

Closed
ThatSilentCoder opened this issue Oct 29, 2024 · 0 comments · Fixed by #865
Closed
Assignees

Comments

@ThatSilentCoder
Copy link
Collaborator

I recently modified one of the modules in checkstyles.xml to ignore checks for Java constants that begin with an underscore. However, after further research and discussions with my colleagues, I believe we should revert this rule and instead update the Java constants to align with recommended Java guidelines. This change will help maintain code consistency and adherence to best practices. Apply the new changes to the entire HIRS_UTILS module.

Revert the following ...

        <module name="ConstantName">
            <property name="format"
                      value="[A-Z_][A-Z0-9]*(_[A-Z0-9]+)*$"/>
        </module>

to this:

<module name="ConstantName"/>

@ThatSilentCoder ThatSilentCoder self-assigned this Oct 29, 2024
@ThatSilentCoder ThatSilentCoder changed the title Undo checkstyle change in checkstyle.xml and apply new changes to HIRS_UTILS Revert Checkstyle rule in Checkstyle.xml and Apply New Changes to HIRS_UTILS Oct 29, 2024
iadgovuser26 added a commit that referenced this issue Nov 8, 2024
…rule-in-checkstylexml

[#864] Undid Constant Name Rule In Checkstyles XML and Applied Formatting/Changes to HIRS_UTILS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant