From 32be88f51143d125d0900e18c32bb15b9ca43cf2 Mon Sep 17 00:00:00 2001
From: nsbradford <nsbradford@gmail.com>
Date: Tue, 31 Oct 2023 01:14:08 +0000
Subject: [PATCH] maybe fix dockerfile

---
 .devcontainer/devcontainer.json | 7 +++----
 Dockerfile                      | 3 ++-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 933d913..1cf35b8 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -32,11 +32,10 @@
 	],
 	"features": {
 		"ghcr.io/devcontainers/features/git:1": {}
-	}
+	},
 
-	// Use 'postCreateCommand' to run commands after the container is created.
-	// TODO yarn install probably should be cached in Dockerfile
-	// "postCreateCommand": "yarn install",
+	// TODO can't get the yarn install within Dockerfile to show up in dev container
+	"postCreateCommand": "yarn install --frozen-lockfile"
 
 	// Configure tool-specific properties.
 	// "customizations": {
diff --git a/Dockerfile b/Dockerfile
index 7cb607d..86ea5d2 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -7,12 +7,13 @@ FROM node:18.15.0-bullseye-slim
 # Set the working directory
 WORKDIR /app
 
-# RUN apk add --no-cache yarn
+# necessary for some of the npm packages
 RUN apt-get update && apt-get install -y \
     python3 \
     make \
     g++
 
+# https://docs.doppler.com/docs/install-cli
 RUN apt-get update && apt-get install -y apt-transport-https ca-certificates curl gnupg && \
     curl -sLf --retry 3 --tlsv1.2 --proto "=https" 'https://packages.doppler.com/public/cli/gpg.DE2A7741A397C129.key' | gpg --dearmor -o /usr/share/keyrings/doppler-archive-keyring.gpg && \
     echo "deb [signed-by=/usr/share/keyrings/doppler-archive-keyring.gpg] https://packages.doppler.com/public/cli/deb/debian any-version main" | tee /etc/apt/sources.list.d/doppler-cli.list && \