[test] Update form-fill.spec.ts #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5b7f2f8 in 39 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_6MWlvrf5v5IoQShR
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -28,6 +28,7 @@ async function runTestScenario( | |||
| const modalContent = await page.textContent('#submissionBox p'); | |||
| const parsed = JSON.parse(modalContent || ''); | |||
| expect(parsed).toEqual(expected); | |||
| expect(1).toEqual(2); | |||
There was a problem hiding this comment.
This line will always cause the test to fail. It seems to be a placeholder or mistake. Consider removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduces a failing test condition in
runTestScenarioinform-fill.spec.ts.expect(1).toEqual(2);inrunTestScenariofunction inform-fill.spec.tsto introduce a failing test condition.This description was created by
for 5b7f2f8. It will automatically update as commits are pushed.