Fix monthly issue metrics workflow #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
===========================================
- Coverage 73.88% 58.72% -15.17%
===========================================
Files 31 13 -18
Lines 2003 1100 -903
===========================================
- Hits 1480 646 -834
+ Misses 523 454 -69 ☔ View full report in Codecov by Sentry. |
mfisher87
approved these changes
Nov 5, 2024
💯 not useful to end-users, would only serve as noise IMO! |
jhkennedy
force-pushed
the
fix-issue-metrics
branch
from
ba84843
to
c460d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our monthly issue metrics GitHub Actions workflow is supposed to close the issue once created, but fails to do so:
https://github.com/nsidc/earthaccess/actions/runs/11623230080/job/32369942886#step:6:10
Failure was because we didn't specify the repo so it tried to base it on a local git repository, but there wasn't one because we don't need to check out the repository for the rest of the action steps.
I've updated the action to have issue write permission (needed for the issue PATCH API request) as well as specifying the repo, which I confirm works in a directory with no git repository:
I don't think there's much value to a changelog entry here, so I've not added one; happy to add one if anyone thinks otherwise.
Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1. SeeGitHub docs - Linking a pull request to an issue.
Update
If such a section does not exist, please create one. FollowCHANGELOG.mdwith details about your change in a section titled## Unreleased.Common Changelog for your additions.
Example PRs: #763
Update the documentation and/or theConsider new environment variables, function names,README.mdwith details of changes to theearthaccess interface, if any.
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-supportteam in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--867.org.readthedocs.build/en/867/