Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reconnect to all connections every time the lookupd job is run #4

Open
werkshy opened this issue Apr 5, 2013 · 2 comments
Open

Don't reconnect to all connections every time the lookupd job is run #4

werkshy opened this issue Apr 5, 2013 · 2 comments

Comments

@werkshy
Copy link
Contributor

werkshy commented Apr 5, 2013

It looks like we call reader.connectToNsqd() for every producer on every poll of lookupd, and we never disconnect from producers that lookupd doesn't respond to.

It seems like we should compare the list that lookupd returns to the list we have open, and open/close connections until we are reconciled.
@danielhfrank
Copy link
Contributor

Yeah, that's correct. Clearly I wrote that only thinking about the initial connection. Will fix once I bring your pull req in

@danielhfrank
Copy link
Contributor

Err, I see you may have actually done some work on this one already. We'll get to it next

@werkshy werkshy mentioned this issue Apr 15, 2013
Closed
werkshy pushed a commit to werkshy/nsq-java that referenced this issue Apr 16, 2013
Move message encode/decode to utility class
966faec 
- New MessageCodec class
- Also remove all import foo.* in non-test code.

Refs Issue nsqio#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@werkshy @danielhfrank