Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Merge NuRadioReco with NuRadioMC #284

Open
anelles opened this issue Jan 5, 2021 · 5 comments
Open

Merge NuRadioReco with NuRadioMC #284

anelles opened this issue Jan 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@anelles
Copy link
Collaborator

anelles commented Jan 5, 2021

NuRadioMC becomes cumbersome to debug/ test automatically if things change here and not there. There are many interdependencies. So from a NuRadioMC standpoint, it would be better to merge them, i.e. have a NuRadioReco folder in the NuRadioMC repository.
Is there anyone, who has an objection to this? Maybe the folks who don't use the neutrino half of things, @fschlueter ?

@anelles anelles added the enhancement New feature or request label Jan 5, 2021
@anelles
Copy link
Collaborator Author

anelles commented Jan 5, 2021

This issue is posted here to document the discussion, so please all contribute, especially @cg-laser who suggested this merger.

@cg-laser
Copy link
Contributor

cg-laser commented Jan 5, 2021

the plan would be to keep NuRadioReco independent in the sense that it would still be a NuRadioReco folder in the NuRadioMC repository and you would still do the same imports via from NuRadioReco.utilities import units for example. But all code development would be in the NuRadioMC repo.
The main reason is that it is super cumbersome to keep new development (and the tests) in sync between MC and Reco.
At the moment, NuRadioMC does not have more (hard) dependencies than NuRadioReco, so installation should be as simple as before, and probably a independent checkout of only the NuRadioReco part would be possible.
Also in the future, we should keep the base version lightweight and require more dependencies only on demand (e.g. proposal for the muon/tau propagation, or RadioPropa for a specific propagation module).

@fschlueter
Copy link
Collaborator

Hi, when described as above by @cg-laser I dont see any problem. It would be important for us to keep NuRadioReco independent itself (with or without an independent checkout) in the future.

@cg-laser
Copy link
Contributor

cg-laser commented Jan 7, 2021

@fschlueter do you have any unmerged branches that you'd want to merge before the transition? We can also ship over branches to NuRadioMC, but this is some work. Things would be easier if everything gets merged to the master before we make the transition.

@fschlueter
Copy link
Collaborator

Hi I will check soon. But there should be nothing major lying around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants