Skip to content

Commit

Permalink
fixes term graceperiod seconds, removes unused env var
Browse files Browse the repository at this point in the history
  • Loading branch information
@nickzelei
nickzelei committed Feb 5, 2025
1 parent 187a313 commit fe81802
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 16 deletions.
3 changes: 0 additions & 3 deletions backend/charts/api/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ OTEL_EXPORTER_OTLP_PORT: {{ .Values.otel.otlpPort | quote }} # sends to gRPC rec
{{- if .Values.nucleusEnv }}
NUCLEUS_ENV: {{ .Values.nucleusEnv }}
{{- end }}
{{- if .Values.shutdownTimeoutSeconds }}
SHUTDOWN_TIMEOUT_SECONDS: {{ .Values.shutdownTimeoutSeconds | quote }}
{{- end }}
{{- if and .Values.auth .Values.auth.enabled }}
AUTH_ENABLED: {{ .Values.auth.enabled | default "false" | quote }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions backend/charts/api/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ spec:
{{- if .Values.serviceAccount.create }}
serviceAccountName: {{ include "neosync-api.serviceAccountName" . }}
{{- end }}
{{- if .Values.terminationGracePeriod }}
terminationGracePeriod: {{ .Values.terminationGracePeriod }}
{{- if .Values.terminationGracePeriodSeconds }}
terminationGracePeriod: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
Expand Down
1 change: 0 additions & 1 deletion docs/docs/deploy/environment-variables.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ These environment variables are loaded when running the `mgmt serve connect` com
| HOST | The host that will be used when binding the HTTP server. Set this to "0.0.0.0" for production environments | false | 127.0.0.1 |
| PORT | The port that will be used to bind the HTTP server | false | 8080 |
| NUCLEUS_ENV | The environment that is being deployed to. Useful for metrics | false | unknown |
| SHUTDOWN_TIMEOUT_SECONDS | Configures the graceful shutdown of a pod in Kubernetes | false | |
| LOGS_FORMAT_JSON | Whether or not to format logs in JSON or in plaintext to stdout | false | true |
| AUTH_ENABLED | Whether or not to enable authentication in the API. Should be required for any production environment | false | false |
| AUTH_BASEURL | The base URL for the authentication server. This is used to find the JWKS URL to validate JWT tokens | false | |
Expand Down
3 changes: 0 additions & 3 deletions frontend/apps/web/charts/app/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ OTEL_EXPORTER_OTLP_PORT: {{ .Values.otel.otlpPort | quote }} # sends to gRPC rec
{{- if .Values.nucleusEnv }}
NUCLEUS_ENV: {{ .Values.nucleusEnv }}
{{- end }}
{{- if .Values.shutdownTimeoutSeconds }}
SHUTDOWN_TIMEOUT_SECONDS: {{ .Values.shutdownTimeoutSeconds | quote }}
{{- end }}
{{- if .Values.neosyncApi.url }}
NEOSYNC_API_BASE_URL: {{ .Values.neosyncApi.url }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions frontend/apps/web/charts/app/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ spec:
{{- if .Values.serviceAccount.create }}
serviceAccountName: {{ include "neosync-app.serviceAccountName" . }}
{{- end }}
{{- if .Values.terminationGracePeriod }}
terminationGracePeriod: {{ .Values.terminationGracePeriod }}
{{- if .Values.terminationGracePeriodSeconds }}
terminationGracePeriod: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
Expand Down
3 changes: 0 additions & 3 deletions worker/charts/worker/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ OTEL_EXPORTER_OTLP_PORT: {{ .Values.otel.otlpPort | quote }} # sends to gRPC rec
{{- if .Values.nucleusEnv }}
NUCLEUS_ENV: {{ .Values.nucleusEnv }}
{{- end }}
{{- if .Values.shutdownTimeoutSeconds }}
SHUTDOWN_TIMEOUT_SECONDS: {{ .Values.shutdownTimeoutSeconds | quote }}
{{- end }}
{{- if .Values.temporal.url }}
TEMPORAL_URL: {{ .Values.temporal.url }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions worker/charts/worker/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ spec:
{{- if .Values.serviceAccount.create }}
serviceAccountName: {{ include "neosync-worker.serviceAccountName" . }}
{{- end }}
{{- if .Values.terminationGracePeriod }}
terminationGracePeriod: {{ .Values.terminationGracePeriod }}
{{- if .Values.terminationGracePeriodSeconds }}
terminationGracePeriod: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.tolerations }}
tolerations:
Expand Down

0 comments on commit fe81802

Please sign in to comment.