Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #130

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

Type of PR:

  • Other

Required reviews:

  • 1

Issues fixed/closed:

@piotr-roslaniec piotr-roslaniec changed the title chore(python): add support for python 3.12 Add support for Python 3.12 Nov 23, 2023
@@ -106,7 +106,7 @@ jobs:
rust:
- stable
python:
- "3.10"
- "3.12"
steps:
- uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: the versions of some of these dependent actions should be updated:

  • checkout: v4
  • setup-python: v4
  • download-artifact: v3
    ...

We can either update these as part of this PR or another one (with issue tracking), but we should update them.

@@ -106,7 +106,7 @@ jobs:
rust:
- stable
python:
- "3.10"
- "3.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this gh action builds and runs tests (please correct me if I'm mistaken), so if we are claiming to support 3.8 all the way up to 3.12, should this python definition actually be a matrix with value ["3.8", "3.12"] instead of a single python version.

Basically, I'm worried about us simply building & testing with 3.12 and then claiming we support older versions. eg. if we add a python 3.12 specific feature, that isn't compatible with older version of python, then the build/test can pass but we aren't actually supporting older versions.

I know that internally we are the only real users of rust-umbral, but it is published separately - so it's good to be consistent with what the library claims to support.

@derekpierre derekpierre mentioned this pull request Dec 1, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8776986) 58.11% compared to head (51da91a) 58.11%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files          17       17           
  Lines        3123     3123           
=======================================
  Hits         1815     1815           
  Misses       1308     1308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@piotr-roslaniec piotr-roslaniec merged commit 47867d2 into nucypher:master Dec 4, 2023
13 of 14 checks passed
@piotr-roslaniec piotr-roslaniec deleted the python-3.12 branch December 4, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants