Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #130

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add support for Python 3.12 #130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5614bd
chore(python): add support for python 3.12
piotr-roslaniec Nov 23, 2023
b7d8f06
chore(ci): bump gh actions versions
piotr-roslaniec Dec 4, 2023
8017f6f
chore(ci): run tests with python 3.8 too
piotr-roslaniec Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/umbral-pre.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
rust:
- stable
python:
- "3.10"
- "3.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this gh action builds and runs tests (please correct me if I'm mistaken), so if we are claiming to support 3.8 all the way up to 3.12, should this python definition actually be a matrix with value ["3.8", "3.12"] instead of a single python version.

Basically, I'm worried about us simply building & testing with 3.12 and then claiming we support older versions. eg. if we add a python 3.12 specific feature, that isn't compatible with older version of python, then the build/test can pass but we aren't actually supporting older versions.

I know that internally we are the only real users of rust-umbral, but it is published separately - so it's good to be consistent with what the library claims to support.

steps:
- uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: the versions of some of these dependent actions should be updated:

  • checkout: v4
  • setup-python: v4
  • download-artifact: v3
    ...

We can either update these as part of this PR or another one (with issue tracking), but we should update them.

- uses: actions/setup-python@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- uses: actions/setup-python@v2
name: Install Python
with:
python-version: '3.8'
python-version: '3.12'

- name: Install cibuildwheel
run: |
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
- uses: actions/setup-python@v2
name: Install Python
with:
python-version: '3.8'
python-version: '3.12'

- name: Install setuptools and setuptools-rust
working-directory: ./umbral-pre-python
Expand Down
2 changes: 2 additions & 0 deletions umbral-pre-python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Topic :: Security :: Cryptography",
],
)
Loading