Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom gm_opts #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

byronpc
Copy link

@byronpc byronpc commented Oct 24, 2017

Add ability to set custom opts without the need to define it in the gm_options module everytime

@nuex
Copy link
Owner

nuex commented Oct 25, 2017

I think the problem can be resolved by just implementing the remaining options in this list: http://www.graphicsmagick.org/GraphicsMagick.html#opti.

@nuex
Copy link
Owner

nuex commented Oct 25, 2017

Or we make it so options are defined dynamically, remove the options clauses altogether, and leave it up to the developer to ensure their options are correct.

@byronpc
Copy link
Author

byronpc commented Oct 26, 2017

The problem with implementing remaining options of gm is it's a temporary fix. As soon as new options are introduced in gm, we have to update the library again. I'm all with letting the developer define the options altogether, from a performance point of view, it will also be faster as you don't need to do all those translating and string manipulations, although we'd need to make note that it will break existing apps using your lib.

@byronpc
Copy link
Author

byronpc commented Oct 26, 2017

or maybe even just expose another api where sending a string will ignore gm_options module instead?

:gm.convert('#{source}', '#{target}', '-strip -opt2 -opt3...')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants