Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error converting metav1.object to runtime object when deleteing and recreating resource before deletion is completed #1

Open
JefeDavis opened this issue Nov 12, 2021 · 1 comment

Comments

@JefeDavis
Copy link
Collaborator

2021-11-12T14:54:35.756-0500    ERROR   controller.tenancycommon        Reconciler error        {"reconciler group": "tenancy.acme.com", "reconciler kind": "TenancyCommon", "name": "tenancycommon-sample", "namespace": "", "error": "unable to complete Check-Ready phase for TenancyCommon, unable to determine if resources are ready, unable to determine ready status for resource, unable to convert metav1.Obect to runtime.Object"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /Users/jeffda/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227

tracked back to

runtimeObj, ok := resource.(runtime.Object)

@JefeDavis
Copy link
Collaborator Author

we should instead use the client.Object interface for all of these calls it's more versatile and include both metav1.object and runtime.Object, it's also the recommended interface for operators to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant