Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FY_2x? #81

Open
bclswl0827 opened this issue Dec 24, 2021 · 11 comments
Open

Support for FY_2x? #81

bclswl0827 opened this issue Dec 24, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@bclswl0827
Copy link

Is your feature request related to a problem? Please describe.
Sanchez doesn't support add false colour to FY_2x.

Describe the solution you'd like
Add support for FY_2x, including add country borders to its false colour image.

Describe alternatives you've considered
Currently it's possible to add false color to FY_2x through GeoSatSignal and CLUT, but this software only supports Windows platform. (https://github.com/eswnl/FY-2x_CLUT)

Additional context
None.

@bclswl0827 bclswl0827 added the enhancement New feature or request label Dec 24, 2021
@nullpainter
Copy link
Owner

Sure thing. Do you have a sample image for me to use?

In the meantime, you should be able to add support by adding a section to the Satellites.json file - see here for details.

@bclswl0827
Copy link
Author

@nullpainter
Copy link
Owner

Thanks! Sanchez uses regular expressions against filenames to determine which satellite configuration to use for each image. Is FY-2x a standard prefix? Or is it FY-2[A-Z]? (e.g., FY-2C, FY-2G, etc.)

@bclswl0827
Copy link
Author

Yes, FY_2x is standard prefix

@creinemann
Copy link

Quick json file addition allows it to work, though your imagery has extra black space surrounding the earth and will have to have cropping adjusted to the json as well to properly line up everything. the crop settings below are just copied from another geo satellite. You can clearly see where the continents don't line up.

{
   "DisplayName": "FY-2H",
   "FilenamePrefix": "FY-2x_1_",
   "FilenameParser": "Goesproc",
   "Invert": false,
   "Longitude": 79.5,
   "Brightness": 1.2,
   "Crop": [
     0.003166,
     0.089925,
     0.001166,
     0.001010
   ]

FY-2x_1_20211101T055509Z-FC

@creinemann
Copy link

What software are you decoding with? I noticed some use the prefix FY_2x while the file you sent has FY-2x_

@bclswl0827
Copy link
Author

SatDump :)

@nullpainter
Copy link
Owner

We can use a regex to support both prefixes. Are the filename date formats and the image alignment the same for all?

If so, all we require is more accurate crop values, as @creinemann noted above. Either you or I can work on this. You can either measure pixels or just divide and conquer.

I can then add the final config to git and create a new release.

@bclswl0827
Copy link
Author

Yes, they're same for all.

@sq7r0
Copy link

sq7r0 commented Jan 13, 2023

unfortunately there will be a problem for exact FY-2H crop values, as every capture has drift. Sat orbit is unstable which results in xy offset on every image

@nullpainter
Copy link
Owner

unfortunately there will be a problem for exact FY-2H crop values, as every capture has drift. Sat orbit is unstable which results in xy offset on every image

I guess there's no EXIF metadata to indicate the offset, he says optimistically...

Before I hard-coded crop values, I had code which tried to guess the crop. This approach works okay for IR images. Perhaps I should resurrect it and use it for FY-2H. May be better than nothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants