Skip to content
This repository has been archived by the owner on Jan 9, 2018. It is now read-only.

Bring up-to-date with Express 4.x #22

Open
edu2004eu opened this issue Jan 13, 2016 · 1 comment
Open

Bring up-to-date with Express 4.x #22

edu2004eu opened this issue Jan 13, 2016 · 1 comment

Comments

@edu2004eu
Copy link

This package doesn't fully work with express 4.x (haven't tested other versions). More specifically, the sending of headers and status is not working, and deprecated respectively.

Fixing this is fairly easy:

Replace this.header('Content-Type', 'text/csv'); with this.set('Content-Type', 'text/csv');
and return this.send(body, headers, status); with:

this.set(headers);
return this.status(status).send(body);
@jczaplew
Copy link

My fork of this should work as expected with express 4.x - https://www.npmjs.com/package/csv-express

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants