Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

De-linting files, Scripts #39

Open
AlbertVas opened this issue Apr 12, 2021 · 1 comment
Open

De-linting files, Scripts #39

AlbertVas opened this issue Apr 12, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@AlbertVas
Copy link

  • File num-node/fhir-server/hapi-fhir-server/application.yml is an (empty) directory (01_start-single-host-environment.sh)
  • No hint to bypass history when specifying a password as parameter - ideally the password would be accepted by the script (00_setup-project-environment.sh)
  • Bash script for nginx which is not used: node-rev-proxy/q_nginx_start.sh
  • File node-rev-proxy/generateCert.sh is named in camel case (in contrast to other files)
  • Could sh-scripts also be directly executable (chmod +x 0*)?
@makampf makampf added the enhancement New feature or request label Apr 13, 2021
@chgl
Copy link
Collaborator

chgl commented Apr 14, 2021

We should consider adding https://github.com/github/super-linter and possibly pre-commit (see https://github.com/miracum/fhir-pseudonymizer/blob/master/.pre-commit-config.yaml) to ensure consistency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants