Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue for warning diagnostics on .setup({...}) with only one non default field #498

Open
pitoniak32 opened this issue Dec 5, 2024 · 0 comments

Comments

@pitoniak32
Copy link

I am just setting a pre_hook option, to override the default nil. But the lua diagnostics are warning about Missing required fields in type CommentConfig.

The docs mention that this should be merged with the default config, I'm wondering if there needs to be a DTO type that marks those fields as optional for the setup function options so they can be merged without warnings. Im not to familiar with lua types though 😅

Following are the default config for the setup(). If you want to override, just modify the option that you want then it will be merged with the default config. Read :h comment.config for more info.

Screenshot 2024-12-05 at 9 11 52 AM

If this would be a medium difficulty fix I would be willing to make a PR if your are accepting contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant