Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo config support #88

Open
2 tasks done
ishan-sharma-me opened this issue Dec 16, 2024 · 3 comments
Open
2 tasks done

Monorepo config support #88

ishan-sharma-me opened this issue Dec 16, 2024 · 3 comments

Comments

@ishan-sharma-me
Copy link

ishan-sharma-me commented Dec 16, 2024

Behavior

  • Turbo monorepo using pnpm. node_modules are in the root directory, react-native project is in apps directory of the root directory.
  • Set up everything according to the instructions and changed the pre-actions script to point the node_modules
$NODE_BINARY "${SRCROOT}/../../../node_modules/react-native-keys/keysIOS.js"
  • build works but the tmp.xcconfig is generated in a ios folder in the root folder whereas it should be generated in apps/react-native-project/ios folder.
  • I think just exposing some env variable we can set in the pre-actions script will solve this

Platform

  • Android
  • iOS
Copy link

👋 @ishan-sharma-me
Thanks for opening your issue here! If you find this package useful hit the star🌟!

@ishan-sharma-me
Copy link
Author

also getting this error while trying to build on android: rn 0.76.3

Configuration on demand is an incubating feature.

/bin/sh: /Users/flek/projects/flek/flek/apps/platform-ui/node_modules/react-native-keys/keysAndroid.js: No such file or directory

> Configure project :app
./keys.development.json
**************************
*** Missing KEYs file ****
**************************
android.packagingOptions.pickFirsts += [**/libcrypto.so] (1)
 ℹ️  Applying gradle plugin 'expo-dev-launcher-gradle-plugin' ([email protected])
  C++ build system [configure] failed while executing:
      /Users/flek/Library/Android/sdk/cmake/3.22.1/bin/cmake \
        -H/Users/flek/projects/flek/flek/node_modules/react-native-keys/android \
        -DCMAKE_SYSTEM_NAME=Android \
        -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
        -DCMAKE_SYSTEM_VERSION=24 \
        -DANDROID_PLATFORM=android-24 \
        -DANDROID_ABI=arm64-v8a \
        -DCMAKE_ANDROID_ARCH_ABI=arm64-v8a \
        -DANDROID_NDK=/Users/flek/Library/Android/sdk/ndk/26.1.10909125 \
        -DCMAKE_ANDROID_NDK=/Users/flek/Library/Android/sdk/ndk/26.1.10909125 \
        -DCMAKE_TOOLCHAIN_FILE=/Users/flek/Library/Android/sdk/ndk/26.1.10909125/build/cmake/android.toolchain.cmake \
        -DCMAKE_MAKE_PROGRAM=/Users/flek/Library/Android/sdk/cmake/3.22.1/bin/ninja \
        "-DCMAKE_CXX_FLAGS=-fexceptions -frtti -std=c++1y -DONANDROID" \
        -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Users/flek/projects/flek/flek/node_modules/react-native-keys/android/build/intermediates/cxx/Debug/4c5q2n1j/obj/arm64-v8a \
        -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=/Users/flek/projects/flek/flek/node_modules/react-native-keys/android/build/intermediates/cxx/Debug/4c5q2n1j/obj/arm64-v8a \
        -DCMAKE_BUILD_TYPE=Debug \
        -DCMAKE_FIND_ROOT_PATH=/Users/flek/projects/flek/flek/node_modules/react-native-keys/android/.cxx/Debug/4c5q2n1j/prefab/arm64-v8a/prefab \
        -B/Users/flek/projects/flek/flek/node_modules/react-native-keys/android/.cxx/Debug/4c5q2n1j/arm64-v8a \
        -GNinja \
        -DANDROID_STL=c++_shared \
        -DNODE_MODULES_DIR=/Users/flek/projects/flek/flek/node_modules \
        -DREACT_NATIVE_MINOR_VERSION=76
    from /Users/flek/projects/flek/flek/node_modules/react-native-keys/android
  CMake Error at CMakeLists.txt:22 (add_library):
    Target "react-native-keys" links to target "ReactAndroid::reactnativejni"
    but the target was not found.  Perhaps a find_package() call is missing for
    an IMPORTED target, or an ALIAS target is missing?
  
  
  CMake Error at CMakeLists.txt:22 (add_library):
    Target "react-native-keys" links to target
    "ReactAndroid::react_nativemodule_core" but the target was not found.
    Perhaps a find_package() call is missing for an IMPORTED target, or an
    ALIAS target is missing?
  
  
  CMake Warning:
    Manually-specified variables were not used by the project:
  
      NODE_MODULES_DIR

@tejasjoshiagile
Copy link

Did you find any solution ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants