Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejig the options around feedback and review #795

Open
christianp opened this issue Sep 26, 2023 · 1 comment
Open

Rejig the options around feedback and review #795

christianp opened this issue Sep 26, 2023 · 1 comment

Comments

@christianp
Copy link
Member

At the moment there are lots of options to do with feedback and review mode, spread across the navigation and feedback tabs. We keep running in to combinations of settings that produce unexpected behaviour. The names of some of the settings are quite ambiguous too.

The LTI tool shows the consequences of these settings in a nice table:

image

I think it would be good to show this table in the editor, with radio buttons or checkboxes to select the desired behaviour.

It would make sense to have the settings in the .exam object match the table more closely. That would involve writing a migration to update old exams, and we'd have to be absolutely certain that the behaviour won't change!

There are some open issues to do with feedback: #754, numbas/Numbas#506.

@christianp
Copy link
Member Author

#576 is related to this.

christianp added a commit to numbas/Numbas that referenced this issue Jul 10, 2024
This commit changes the .exam schema, rejigging how many of the feedback
settings work.

The aims are to:

* Make the feedback settings in the editor easier to understand
  (see numbas/editor#795)
* Allow a "completed but not revealed" mode, where students can see the
  questions and their answers, but not necessarily any feedback.

The settings `showActualMark`, `showTotalMark`, `showAnswerState` and
the new setting `showPartFeedbackMessages` are now strings, taking
values from ["always", "oncompletion", "inreview", "never"].

The settings `reviewShowScore` and `reviewShowFeedback` have been
removed, since their behaviour is described by the changed `showX` settings.

The `showResultsPage` setting has been removed and there's a new setting
`enterReviewModeImmediately` which determines what happens when you end
the exam.

The settings `reviewShowExpectedAnswer` and `reviewShowAdvice` are now
`revealExpectedAnswers` and `revealAdvice`, with values in ["inreview",
"never"].

These settings give more fine-grained control over when feedback is
revealed: you might want to show students expected answers as soon as
the exam is finished, but not show how their answers were marked until a
later date.

We imagine that "enterReviewModeImmediately" will be false for summative
assessments, and the LTI tool will let students open attempts in review
mode once the deadline has passed.

There's an exam data migration which automatically upgrades old exams to
the new schema.

We still need to add unit tests for this behaviour. I'm not sure how
much of it can be tested, since a lot of the logic is in the display
code.
christianp added a commit to numbas/numbas-lti-provider that referenced this issue Jul 12, 2024
…eview is allowed.

See numbas/editor#795

If review mode is not allowed yet, a student can still enter an exam,
but in the "just completed" mode, so they might not see all feedback,
depending on the exam's feedback settings.

The attempts listing page shows when each kind of feedback is available.
christianp added a commit to numbas/Numbas that referenced this issue Sep 18, 2024
This commit changes the .exam schema, rejigging how many of the feedback
settings work.

The aims are to:

* Make the feedback settings in the editor easier to understand
  (see numbas/editor#795)
* Allow a "completed but not revealed" mode, where students can see the
  questions and their answers, but not necessarily any feedback.

The settings `showActualMark`, `showTotalMark`, `showAnswerState` and
the new setting `showPartFeedbackMessages` are now strings, taking
values from ["always", "oncompletion", "inreview", "never"].

The settings `reviewShowScore` and `reviewShowFeedback` have been
removed, since their behaviour is described by the changed `showX` settings.

The `showResultsPage` setting has been removed and there's a new setting
`enterReviewModeImmediately` which determines what happens when you end
the exam.

The settings `reviewShowExpectedAnswer` and `reviewShowAdvice` are now
`revealExpectedAnswers` and `revealAdvice`, with values in ["inreview",
"never"].

These settings give more fine-grained control over when feedback is
revealed: you might want to show students expected answers as soon as
the exam is finished, but not show how their answers were marked until a
later date.

We imagine that "enterReviewModeImmediately" will be false for summative
assessments, and the LTI tool will let students open attempts in review
mode once the deadline has passed.

There's an exam data migration which automatically upgrades old exams to
the new schema.

We still need to add unit tests for this behaviour. I'm not sure how
much of it can be tested, since a lot of the logic is in the display
code.
christianp added a commit to numbas/numbas-lti-provider that referenced this issue Sep 24, 2024
…eview is allowed.

See numbas/editor#795

If review mode is not allowed yet, a student can still enter an exam,
but in the "just completed" mode, so they might not see all feedback,
depending on the exam's feedback settings.

The attempts listing page shows when each kind of feedback is available.
christianp added a commit to numbas/numbas-lti-provider that referenced this issue Oct 10, 2024
…eview is allowed.

See numbas/editor#795

If review mode is not allowed yet, a student can still enter an exam,
but in the "just completed" mode, so they might not see all feedback,
depending on the exam's feedback settings.

The attempts listing page shows when each kind of feedback is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant