Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I mod your work #1

Open
123JRM opened this issue Nov 16, 2020 · 3 comments
Open

I mod your work #1

123JRM opened this issue Nov 16, 2020 · 3 comments

Comments

@123JRM
Copy link

123JRM commented Nov 16, 2020

hello,

I modified flvdec.c and flvenc.c to work with the latest autobuild for windows. I forked your build but I do not know how to give you credit for your work and create another build using those files and the autobuild for windows. how would you like me to proceed ?

@123JRM
Copy link
Author

123JRM commented Nov 20, 2020

hello,

I think i should be asking you to update your ffmpeg files to the newest version and I have included the files i modified to work with the latest ffmpeg.

flv_files_changed.zip

@numberwolf
Copy link
Owner

Hi,
You can commit your code by pull request, its easy to review

@123JRM
Copy link
Author

123JRM commented Nov 26, 2020

I think i need to instead fork the main ffmpeg because that is what I made with your files and give you credit. I can not make your repository work because I am modifying your files to work with the new ffmpeg not your version. I will give you credit and leave your signature comments inside your files. I hope this works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants