Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W4.4b][T09-A4]JOHNNY CHAN JUN XUN #1706

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
db3978d
Update regex for better Name matching
okkhoy Aug 30, 2016
730ea58
fix tests to clean up all entries before closing
okkhoy Aug 30, 2016
c3ac0d5
Merge branch 'master' into fix-Name-regex
okkhoy Oct 5, 2016
cec9204
add more tests to check for dash, dot, qote and unicode characters in…
okkhoy Oct 5, 2016
adef5c6
fixed regex to "^[\\p{L}0-9 .'-]+$", the prev one did not have numbers
okkhoy Oct 5, 2016
bf7f6bc
add more test case to test name with numbers (the latest fix)
okkhoy Oct 5, 2016
8928fef
convert input and expected to UTF-8 encoding.
okkhoy Oct 6, 2016
02b59fc
encoding to UTF-8 w/o BOM for input and actual
okkhoy Oct 20, 2016
c61e65b
[41] Name regex doesn't match hyphen, dots and quote
ndt93 Oct 21, 2016
2283852
Add codacy badge
damithc Nov 27, 2016
43c506d
[#101] Remove unused imports (#114)
jia1 Dec 7, 2016
7518552
[#102] Fix coding problem: reassigning parameters (#115)
jia1 Dec 8, 2016
f196968
[#109] Add unit tests for DeleteCommand class (#119)
yamgent Dec 10, 2016
88133a6
[#108] Add unit tests for AddCommand class (#118)
Neurrone Dec 11, 2016
7d1de69
[#124] Fix code style violation (#125)
yamgent Dec 13, 2016
1a15e66
[#107] Add unit tests for Utils class (#127)
zzzzwen Dec 22, 2016
24335db
[#104] Add unit tests for StorageFile class (#128)
zzzzwen Dec 28, 2016
753fcc1
[#133] Test Failing due to incorrect message (#135)
zzzzwen Jan 2, 2017
a909e09
[#110] Add unit tests for FindCommand class (#120)
Jan 3, 2017
2fdb124
[#130] Change file extension requirement from .txt to .xml (#132)
zzzzwen Jan 3, 2017
70f60ba
[#117] Names with unicode characters are treated as invalid (#138)
Neurrone Jan 8, 2017
03e0b27
[#105] Add unit tests for AddressBook class (#121)
thenaesh Jan 8, 2017
9b3434b
[#99] Rephrase method header comments to follow the convention (#139)
MightyCupcakes Jan 14, 2017
07adaee
[#96] Phone::isValidPhone rephrase header comment (#141)
MightyCupcakes Jan 14, 2017
7d0987d
[#112] Set up Travis CI (#140)
yamgent Jan 15, 2017
5e55b71
[#122] Add different levels of comparison to equality methods of Pers…
Neurrone Jan 15, 2017
f92b1d0
[#111] Add unit tests for ViewAllCommand and ViewCommand classes (#131)
zzzzwen Jan 17, 2017
8dfc604
Add checkstyle to gradle
yamgent Jan 16, 2017
c348297
Fix checkstyle rule violations in main classes
yamgent Jan 21, 2017
a2b49d0
Fix checkstyle rule violations in tests
yamgent Jan 21, 2017
15b1751
Generate gradle wrapper
yamgent Jan 21, 2017
5810f7c
[#123] Set up checkstyle (#145)
damithc Jan 31, 2017
2ef44b2
Move handling of missing file to normal code path
yamgent Jan 14, 2017
44ceadb
Remove creating new file on load()
yamgent Jan 14, 2017
adf4aef
Add unit test for loading non-existent files
yamgent Jan 21, 2017
7492790
[#129] StorageFile class: load method should not create a new file (#…
damithc Feb 13, 2017
419ec2b
AddressBook: remove unused addTag()
PierceAndy Feb 9, 2017
84c8535
UniqueTagList: remove unused add()
PierceAndy Feb 11, 2017
fb8863d
AddressBook: remove unused removeTag()
PierceAndy Feb 9, 2017
4e3fac9
UniqueTagList: remove unused remove()
PierceAndy Feb 11, 2017
a6cc952
AddressBook: remove unused containsTag()
PierceAndy Feb 9, 2017
4f5b987
[#169] Addressbook::addTag() is not used (#179)
damithc Feb 20, 2017
c3c63de
[#144] Fix typo in header comment (#186)
limmlingg Mar 15, 2017
d238818
[#103] ParserTest: fix naming standard violation (#188)
luyangkenneth Mar 28, 2017
816c503
Set theme jekyll-theme-cayman
damithc Apr 1, 2017
2d5071d
[#146] Run I/O tests in CI (#189)
chao1995 Apr 7, 2017
1603ad0
[#191] runtest.sh: fix bug in deleting actual.txt from previous run (…
chao1995 Apr 14, 2017
ae4464f
[#200] Migrate docs to use Intellij instead of Eclipse (#201)
limmlingg Jul 25, 2017
08e7bcd
[#202] Remove Eclipse project files (#203)
limmlingg Jul 26, 2017
e7df84a
[#205] DeveloperGuide: Improve project setup instructions (#206)
yamgent Aug 28, 2017
a8cd67f
README: update Contributors to refer to se-edu
eugenepeh Aug 29, 2017
ad71877
[#204] README: update Contributors to refer to se-edu (#207)
Zhiyuan-Amos Aug 30, 2017
f94fe28
LearningOutcomes.md: tweak LOs to refer to se-book
damithc Aug 31, 2017
de7ef4a
Command class: make non-abstract
damithc Aug 31, 2017
2b706ae
[#190] docs: change system tests to I/O tests
damithc Aug 31, 2017
5d095e8
LOs: update LO-Exceptions to mention read-only files
damithc Sep 5, 2017
96597cc
LOs/LO-ImplementClasses: mention meaning of diamond symbol
damithc Sep 5, 2017
4991eed
Fix typo in VERSION string with incorrect spelling of AddressBook
500poundbear Sep 4, 2017
74ec38a
[#208] DeveloperGuide: Change setup to use default test configuration…
yamgent Sep 10, 2017
23644b1
[#209] Main#VERSION: Fix typo
Zhiyuan-Amos Sep 11, 2017
3d6645b
Encapsulation of getFeedbackToUser variable
johnnychanjx Feb 7, 2018
5000279
Splits Address into 4 different Classes
johnnychanjx Feb 7, 2018
9a86a6e
Splits Address into 4 different Classes
johnnychanjx Feb 7, 2018
9193f7e
Updated User Guide
johnnychanjx Feb 7, 2018
44785b1
Catch Exception during Read-Only
johnnychanjx Feb 7, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
8 changes: 0 additions & 8 deletions .classpath

This file was deleted.

9 changes: 6 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Default storage file for addressbook : don't need to cleanup when running from IDE

addressbook.txt
addressbook.xml

# Compiled classfiles
bin/
Expand All @@ -10,7 +10,6 @@ bin/
.mtj.tmp/

# Package Files #
*.jar
*.war
*.ear

Expand All @@ -23,4 +22,8 @@ hs_err_pid*

# Temp files used for testing
test/actual.txt
test/localrun.bat
test/localrun.bat

# Gradle build files
.gradle/
build/
17 changes: 0 additions & 17 deletions .project

This file was deleted.

11 changes: 0 additions & 11 deletions .settings/org.eclipse.jdt.core.prefs

This file was deleted.

13 changes: 13 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
language: java
matrix:
include:
- jdk: oraclejdk8

script:
- (cd test && ./runtests.sh) # I/O tests
- (./gradlew clean test) # JUnit tests

addons:
apt:
packages:
- oracle-java8-installer
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[![Build Status](https://travis-ci.org/se-edu/addressbook-level2.svg?branch=master)](https://travis-ci.org/se-edu/addressbook-level2)
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/ad7aa7caa7ba4d40aef9440b16ea68d6)](https://www.codacy.com/app/se-edu/addressbook-level2?utm_source=github.com&utm_medium=referral&utm_content=se-edu/addressbook-level2&utm_campaign=Badge_Grade)

# AddressBook (Level 2)
* This is a CLI (Command Line Interface) Address Book application **written in OOP fashion**.
* It is a Java sample application intended for students learning Software Engineering while using Java as
Expand All @@ -12,11 +15,10 @@

# Contributors

* [Leow Yijin](http://github.com/yijinl) : Main developer for AddressBook-level2
* [Damith C. Rajapakse](http://www.comp.nus.edu.sg/~damithch) : Project Advisor
The full list of contributors for se-edu can be found [here](https://se-edu.github.io/docs/Team.html).

# Contact Us

* **Bug reports, Suggestions** : Post in our [issue tracker](https://github.com/se-edu/addressbook-level2/issues)
if you noticed bugs or have suggestions on how to improve.
* **Contributing** : We welcome pull requests. Follow the process described [here](https://github.com/oss-generic/process)
* **Contributing** : We welcome pull requests. Follow the process described [here](https://github.com/oss-generic/process)
1 change: 1 addition & 0 deletions _config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
theme: jekyll-theme-cayman
38 changes: 38 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
allprojects {
apply plugin: 'java'
apply plugin: 'checkstyle'

repositories {
jcenter()
mavenCentral()
}

project.ext {
checkstyleVersion = '7.1.2'
}

checkstyle {
toolVersion = "$checkstyleVersion"
}

sourceSets {
main {
java {
srcDirs = ['src']
}
}
test {
java {
srcDirs = ['test/java']
}
}
}

dependencies {
testCompile 'junit:junit:4.12'
}
}

task wrapper(type: Wrapper) {
gradleVersion = '2.12'
}
Loading