-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T8][F09-C3] #152
base: master
Are you sure you want to change the base?
[T8][F09-C3] #152
Conversation
Hi @antoniadevina, your pull request title is invalid. It should be in the format of Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
Great, I found you all. :) I will review soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Keep up the good work! ^^
3. Should come with automated unit tests and open source code. | ||
4. Should favor DOS style commands over Unix-style commands. | ||
2. Should come with automated unit tests and open source code. | ||
3. User must get the command done within three mouse clicks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to have no click for Jim :P
4. The total file size must be less than 15MB | ||
5. Search result must be returned in 0.3ms | ||
6. Buttons and text field must be clearly labeled | ||
7. Make the more important/urgent tasks stand out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How? What do you mean by stand out? It doesn't sound like a non-functional requirement. :)
5. Search result must be returned in 0.3ms | ||
6. Buttons and text field must be clearly labeled | ||
7. Make the more important/urgent tasks stand out | ||
8. The longer events will look different from shorter events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be something user would wish to see instead of non functional requirement
#### Listing all persons : `list` | ||
Shows a list of all persons in the address book.<br> | ||
Format: `list` | ||
#### Adding or changing deadline of a task : `deadline` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can done this after implementing edit?
> * Only the task/event title is searched. | ||
> * Only full words will be matched e.g. `socc` will not match `soccer` | ||
> * Task or event matching at least one keyword will be returned (i.e. `OR` search). | ||
e.g. `soccer` will match `soccer training` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider yourself as a user, what kind of the search function is better to you? :)
Please open a new pull request @antoniadevina :) :) |
Fix mark and unmark
Command Box now will resume to normal when entering new text
"list mark " "list unmark" "list future" "list past" "list 21 oct" "list 21 oct mark" "list 21 oct unmark" "list" possible improvement: "list next week"
some test case are dependent on mark (integrated test case?)
* Add_ListCommand: make a test case and passed all test case. some test case are dependent on mark (integrated test case?) Enhance list Now it is possible to execute: "list mark " "list unmark" "list future" "list past" "list 21 oct" "list 21 oct mark" "list 21 oct unmark" "list" possible improvement: "list next week" Fix the logic in Date time Info Enhance list class: list future list pass list mark list unmark # Conflicts: # src/main/java/seedu/flexitrack/logic/commands/ListCommand.java # src/main/java/seedu/flexitrack/logic/parser/Parser.java
* Add_ListCommand_next_and_last: Fix: next week last week next month last month trying to add next and last. but i get run time error # Conflicts: # src/main/java/seedu/flexitrack/logic/parser/Parser.java Edit test case still doesn't work i think. so travis will be failing
TODO: method header (undone commit)
To do: Fix test cases
…_and_Test_Case Clean up list command and test case
Add undo command
…2016-F09-C3/main into Add_manual_test_script
Add manual test script
Add undo/redo implementation
scroll when flexi tracked is changed
No description provided.