[W8.6b][W09-B4] Chua Li Qun Shawn #961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove isPrivate attribute from Block, Unit, Street and PostalCode.
… for additional Block, Street, Unit and PostalCode classes
…nit and PostalCode classes
goweiwen
reviewed
Mar 18, 2018
| /** | ||
| * Adds tagging to class-level variable that stores all taggings | ||
| */ | ||
| public static void addTagging(Tagging tagging) { |
There was a problem hiding this comment.
This forces the caller to manually call addTagging after creating a new Tagging. If he doesn't, the doc comment for getTaggings will be incorrect. One way to solve this would be to move this method into the constructor. Alternatively, a new singleton TaggingList class can be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the commits on 14th March is significant for this LO!