-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W5.11r][F14-B4] Liu Jianghao #757
base: master
Are you sure you want to change the base?
Conversation
added sort to test case
Hi @fishTT, your pull request title is invalid. For phase A, it should be in the format of For phase B, it should be in the format of Please follow the instructions given strictly and edit your title for reprocessing. Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
This reverts commit 5d8a3ce.
edited title for reprocessing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good implementation. But you should read the coding standard more carefully and format your code correctly. Also, please update the test cases and documentation :)
@@ -16,6 +16,7 @@ | |||
+ "\n" + ClearCommand.MESSAGE_USAGE | |||
+ "\n" + FindCommand.MESSAGE_USAGE | |||
+ "\n" + ListCommand.MESSAGE_USAGE | |||
+ "\n" + SortCommand.MESSAGE_USAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding standard violation!
*/ | ||
public void sort() { | ||
internalList.sort( | ||
Comparator.comparing((Person p) -> p.getName().toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation of this line should be 8 more spaces than the previous line.
added sort method
added sort to UserGuide and test