[v1.2][T11-B1] TuitionConnect #45
Conversation
|
Hi @raymond511, your pull request title is invalid. For phase A, it should be in the format of For phase B, it should be in the format of Please follow the instructions given strictly and edit your title for reprocessing. Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
raymond511
changed the title
|
It is noticed that some of the builds (including the build of this PR) failed the Travis CI due to checkstyle issues. Please try to ensure that each PR passes Travis before merging into master branch. This will help you isolate future broken commits. The main reason for Travis failures is checkstyle issues. Thus please ensure that proper coding standards are adhered to. IntelliJ can check the coding standard for you to see if you violate checkstyle in any way, refer to the course website to see how you can configure that. |
README.adoc
Outdated
| @@ -1,9 +1,9 @@ | |||
| = Address Book (Level 4) | |||
There was a problem hiding this comment.
I guess your project is not Address Book anymore :p, please update the Address Book mentions from all instances. You might also need to update or remove stuff that relates only to address-book and not to your project.
README.adoc
Outdated
| @@ -1,9 +1,9 @@ | |||
| = Address Book (Level 4) | |||
| ifdef::env-github,env-browser[:relfileprefix: docs/] | |||
|
|
|||
| https://travis-ci.org/se-edu/addressbook-level4[image:https://travis-ci.org/se-edu/addressbook-level4.svg?branch=master[Build Status]] | |||
| https://travis-ci.org/CS2103JAN2018-T11-B1/main[image:https://travis-ci.org/se-edu/addressbook-level4.svg?branch=master[Build Status]] | |||
There was a problem hiding this comment.
Good to see that the Travis link has been updated.
docs/DeveloperGuide.adoc
Outdated
|
|
||
| |`*` |tutor |take note of the name of my student's school teachers |adjust my teaching according to the school teacher. | ||
|
|
||
| |`*` |tutor |insert my student's photo | | ||
| |======================================================================= | ||
|
|
||
| _{More to be added}_ |
There was a problem hiding this comment.
This comment can be removed if no more stories are planned to be added.
docs/DeveloperGuide.adoc
Outdated
|
|
||
| [discrete] | ||
| === Use case: Delete person | ||
| === Use case: UC01-Delete person |
There was a problem hiding this comment.
Upon rendering, this is not having D.x tag, while the rest use-cases do. Please fix this inconsistency.
| @@ -852,6 +1033,16 @@ _{More to be added}_ | |||
| . Should work on any <<mainstream-os,mainstream OS>> as long as it has Java `1.8.0_60` or higher installed. | |||
| . Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage. | |||
There was a problem hiding this comment.
As discussed in the tutorial, vague terms like "noticeable sluggishness", "average speed", etc., should be avoided in NFRs.
raymond511
changed the title
docs/AboutUs.adoc
Outdated
|
|
||
| ''' | ||
|
|
||
| === Benson Meier | ||
| === Shakra Anas | ||
| image::yl_coder.jpg[width="150", align="left"] |
|
@ChoChihTun @raymond511 @a-shakra @yungyung04 Looks good. Nice work. You may want to fix the broken pictures in the About Us. |
raymond511
changed the title
…1.3YuxiangSg V1.3 yuxiangsg
[V1.5][T11-B1]Anas Shakra | Varied Sample Tasks for Project Demo
[V1.5][T11-B1]Eka Buyung | Glossary, final checks
[v1.5][T11-B1] Cho Chih Tun - update date and time
Minor edit and collate
[v1.5] Raymond Zheng Update encryption
Revert "[v1.5]
…58-master Revert "Revert "[v1.5]"
@ChoChihTun @raymond511 @a-shakra @yungyung04
Reasonable attempts for component enhancements can be found in our team repo.
User stories can be found in our team repo's Project tab, User Stories.
A draft project document can be found in our Google doc.