[v1.5][F09-B3] CoinBook #62

laichengyu · 2018-03-08T13:06:12Z

… cases to test for Command aliases

This reduces the amount of typing needed by the user to call the commands.

- Add empty `backupAddressBook' method to `AddressBookStorage' interface - Implement `backupAddressBook' method in `XmlAddressBookStorage' class. - Implement `backupAddressBook' method for `StorageManager' by calling `AddressBookStorage''s backup method

* PersonCard#tags: Add colors to the labels * NewResultAvailableEvent: Add error flag * ResultDisplay: Make it actually set error style * StatusBarFooter: Implement support for item count * Update all tests

- UserGuide.adoc: Update links - README.adoc: Update badges Add acknowledgements to se-edu - DeveloperGuide.adoc: Update links Add more NFRs Add User Stories Add target user profile Add glossary Add Use cases Fix formatting in Sections 1,4,5,6 - build.gradle: Add trailing whitespace autofix for docs - Disable `CATASTROPHIC FAILURE: Whitespace errors'

- Add UI mockup image - Add profile photos

* Add FetchUtil commons class * Add method to deserialize an array of JSON objects

* NewsCard: Add class and fxml to contain news links * NewsListPanel: Add class and fxml to contain `NewsCards' * MainWindow: Add `BrowserWindow' to open links when NewsCards are clicked on

* New fork, New team * Fix image format. * Create portfolio files.

* ChartsPanel: Make a new UI component for drawing charts * ChartPanel: Add sample data * Prepare for integration with web API

* ChartsPanel: Unchecked assignment to generics * Fix Checkstyle warnings

* BrowserWindow: Make this handle both help and web pages * MainWindow#handleHelp(): Use `BrowserWindow' for help page * Refactor jUnit tests to use `BrowserWindow' instead of `HelpWindow'

k-l-a

Please update the UG to document all features up to V2.0, and mark them accordingly. Update your Readme title to reflect your product name, as well. This was required for last week's team component. Therefore, it has to be considered missed.

Also, please update the title of this PR to reflect your product version each time you release a new version. (e.g. [v1.1])

@laichengyu @eldon-chung @ewaldhew @neilish3re
Furthermore, I would want you to mention the following in your Developer guide

For each team member what are the features (major and minor) you are proposing?
Within the scope of the project, how does it fit in (just a one or 2 line summary)
Please do this by end of day Monday 19 March.

k-l-a · 2018-03-18T13:17:22Z

README.adoc

-https://gitter.im/se-edu/Lobby[image:https://badges.gitter.im/se-edu/Lobby.svg[Gitter chat]]
+https://travis-ci.org/CS2103JAN2018-F09-B3/main[image:https://travis-ci.org/CS2103JAN2018-F09-B3/main.svg?branch=master[Build Status]]
+https://ci.appveyor.com/project/ewaldhew/main[image:https://ci.appveyor.com/api/projects/status/anm4ynat6657reac?svg=true[Build Status]]
+https://coveralls.io/github/CS2103JAN2018-F09-B3/main?branch=master[image:https://coveralls.io/repos/github/CS2103JAN2018-F09-B3/main/badge.svg?branch=master[Coverage Status]]


Good to see you've updated these.

k-l-a · 2018-03-18T13:45:06Z

src/main/java/seedu/address/model/CryptoCompareHistoHourObject.java

+    }
+
+    /**
+     * Get the price history (per day open) data


Should be Gets instead of Get to be consistent. Maybe use Returns to be more precise, instead.

* Add coin icons to panels

* Reduce icon db to 100 items

* ActionCommand: Receive additional information from event * CoinChangedEvent: Store index of changed coin

* Add loading ui

* Add UrlBuilderTests

* Notification Tests * ModelManagerTest: Add rule tests

* Fix negative amounts and better print

* Add FetchUtil tests * Refactor FetchUtil and SyncCommand

* Remove nonsensical prefixes * Remove held, bought, sold, made conditions * WorthChangeCondition, ConditionGeneratorTest: Fix calculations

* Edit asyncFetch comments and javadoc

#57 * SyncCommand: Get historical prices * SyncCommand: Factor out fetch procedures * Price: Add lists to store historical data * ChartsPanel: Add to app * ChartsPanel: Add processing for coin data * MainWindow: Add new panel * Author annotation

* Update UserGuide * Update PPP * Update autocomplete in DG * Update dev guide

* Update UserGuide * Update PPP * Update DeveloperGuide

* Edit UGDG * Edit Diagrams * Notifications and various doc fixes

* Fix UG typos

* Notifications: Add coin icon * IconUtil: Move icon getter to this file * CoinListCard: Move amount display to right edge * StatusBarFooter: Add filter status * MainWindow: Reset filter before notification coin jump * DarkTheme: Tweak colors * StatusBarFooter: Make new element for filter

* UserGuide: Update * DeveloperGuide: Fix figure numbers * UserGuide: Warn about find filtering * UserGuide: Use basic xref label * Final edits

eldon-chung and others added 4 commits March 8, 2018 12:07

Add COMMAND_ALIAS as an attribute to each command.

cdfa095

Modify AddressBookParser to recognise Command aliases and modify test…

946207f

… cases to test for Command aliases

Update the user guide to mention command aliases

898b71a

[#9] Add support for command aliases (#13)

4d4293d

This reduces the amount of typing needed by the user to call the commands.

nus-se-pr-bot added team.B3 tutorial.F09 labels Mar 8, 2018

nus-se-pr-bot assigned okkhoy and k-l-a Mar 8, 2018

laichengyu and others added 19 commits March 8, 2018 23:21

Add backupAddressBook method to AddressBookStorage interface

5608594

Add overloaded backupAddressBook method

8922b92

Remove unneeded overloaded method

d85fbbe

Add backupAddressBook method to StorageManager class

4078d53

Add backupAddressBook method to XmlAddressBookStorage class

cd403d8

Remove trailing whitespaces

cd24669

[#11] Various UI enhancements (#16)

b1f1643

* PersonCard#tags: Add colors to the labels * NewResultAvailableEvent: Add error flag * ResultDisplay: Make it actually set error style * StatusBarFooter: Implement support for item count * Update all tests

Update docs images (#32)

bd1f5b8

- Add UI mockup image - Add profile photos

[#23] README.adoc: Add product description (#31)

a259c0b

[#25] Add fetch utility class to obtain data from external APIs (#39)

83ff03a

* Add FetchUtil commons class * Add method to deserialize an array of JSON objects

[#28] Add news panel (#34)

32b2fc3

* NewsCard: Add class and fxml to contain news links * NewsListPanel: Add class and fxml to contain `NewsCards' * MainWindow: Add `BrowserWindow' to open links when NewsCards are clicked on

[#21] UserGuide: Update user guide to describe the project (#38)

674fa0c

[#22] AboutUs.adoc: Update with own team (#35)

9faee50

* New fork, New team * Fix image format. * Create portfolio files.

[#27] Charts panel component (#33)

ae6f59d

* ChartsPanel: Make a new UI component for drawing charts * ChartPanel: Add sample data * Prepare for integration with web API

v1.1: Fix warnings (#42)

2710200

* ChartsPanel: Unchecked assignment to generics * Fix Checkstyle warnings

Version 1.1 released (#48)

746c28d

[#36] Merge browser window (#47)

ca959c7

* BrowserWindow: Make this handle both help and web pages * MainWindow#handleHelp(): Use `BrowserWindow' for help page * Refactor jUnit tests to use `BrowserWindow' instead of `HelpWindow'

k-l-a reviewed Mar 18, 2018

View reviewed changes

k-l-a added the reviewed-v1_1 label Mar 18, 2018

laichengyu changed the title ~~[v1.0][F09-B3] CoinBook~~ [v1.1][F09-B3] CoinBook Mar 18, 2018

laichengyu and others added 29 commits April 14, 2018 18:30

[#226] Add coin icons to panels (#233)

11ecdf3

* Add coin icons to panels

Reduce icon db to 100 items (#239)

37aa619

* Reduce icon db to 100 items

Fix Rule Actions (#240)

e121998

* ActionCommand: Receive additional information from event * CoinChangedEvent: Store index of changed coin

[#126] Add loading ui (#241)

2aa57cd

* Add loading ui

Update dev guide, user guide and PPP (#234)

53d69fb

Add UrlBuilderTests (#242)

4987787

* Add UrlBuilderTests

Notifications: Add tests (#243)

e2ea134

* Notification Tests * ModelManagerTest: Add rule tests

Amount: Disallow negative, Better print (#244)

b0f86ec

* Fix negative amounts and better print

Add authorship (#246)

3670543

Add FetchUtil tests (#245)

a541e8c

* Add FetchUtil tests * Refactor FetchUtil and SyncCommand

MainApp: Add tests (#249)

5c6f2b7

SyncCommand: Add tests (#247)

c55008c

Remove unused methods (#248)

63305b1

Notification Conditions: Fix calculations, Remove useless (#250)

d76ff01

* Remove nonsensical prefixes * Remove held, bought, sold, made conditions * WorthChangeCondition, ConditionGeneratorTest: Fix calculations

Attempt to fix coveralls badge (#253)

948c58c

Edit Async fetch comments (#251)

40f0708

* Edit asyncFetch comments and javadoc

[#57] Charts Panel (#256)

dc16761

#57 * SyncCommand: Get historical prices * SyncCommand: Factor out fetch procedures * Price: Add lists to store historical data * ChartsPanel: Add to app * ChartsPanel: Add processing for coin data * MainWindow: Add new panel * Author annotation

UGDG/PPP(laichengyu): Update (#259)

2d53f8c

* Update UserGuide * Update PPP * Update autocomplete in DG * Update dev guide

DevGuide update (#261)

df4c76d

* Update UserGuide * Update PPP * Update DeveloperGuide

Documentation updates (Notifications) (#260)

4110863

* Edit UGDG * Edit Diagrams * Notifications and various doc fixes

Update User Guide, Dev Guide and PPP (#257)

02ad6f1

Fix UG typos (#264)

0ae352a

* Fix UG typos

Include sync feature in DG (#266)

f2ea6c3

Final edits (#267)

9ad2d77

* UserGuide: Update * DeveloperGuide: Fix figure numbers * UserGuide: Warn about find filtering * UserGuide: Use basic xref label * Final edits

SyncCommand: Prevent crash when internet connection out (#268)

794dcbd

Final PPP (#269)

af3937c

Fill in final missing documentation (#270)

42fe647

Version 1.5 released (#271)

d5062fe

laichengyu changed the title ~~[v1.5rc][F09-B3] CoinBook~~ [v1.5][F09-B3] CoinBook Apr 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v1.5][F09-B3] CoinBook #62

[v1.5][F09-B3] CoinBook #62

laichengyu commented Mar 8, 2018

k-l-a left a comment •

edited

Loading

k-l-a Mar 18, 2018

k-l-a Mar 18, 2018

[v1.5][F09-B3] CoinBook #62

Are you sure you want to change the base?

[v1.5][F09-B3] CoinBook #62

Conversation

laichengyu commented Mar 8, 2018

k-l-a left a comment • edited Loading

Choose a reason for hiding this comment

k-l-a Mar 18, 2018

Choose a reason for hiding this comment

k-l-a Mar 18, 2018

Choose a reason for hiding this comment

k-l-a left a comment •

edited

Loading