-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.5][F12-B2] Personal Trainer Pro #72
base: master
Are you sure you want to change the base?
[v1.5][F12-B2] Personal Trainer Pro #72
Conversation
Hi @hypertun, your pull request title is invalid. For phase A, it should be in the format of For phase B, it should be in the format of Please follow the instructions given strictly and edit your title for reprocessing. Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important Do remember to give credit to code sources if your code is inspired from elsewhere. Just changing the variable names will not help - we will still be able to tell that it has been adapted. Please follow the guidelines as given in the learning resources!
Also please do not close this PR as we will use it to track your progress.
https://coveralls.io/github/se-edu/addressbook-level4?branch=master[image:https://coveralls.io/repos/github/se-edu/addressbook-level4/badge.svg?branch=master[Coverage Status]] | ||
https://travis-ci.org/CS2103JAN2018-F12-B2/main[image:https://travis-ci.org/CS2103JAN2018-F12-B2/main.svg?branch=master[Build Status]] | ||
https://ci.appveyor.com/project/hypertun/main/branch/master[image:https://ci.appveyor.com/api/projects/status/690sw2r4l3lxa1fr/branch/master?svg=true[Build status]] | ||
https://coveralls.io/github/CS2103JAN2018-F12-B2/main?branch=master[image:https://coveralls.io/repos/github/CS2103JAN2018-F12-B2/main/badge.svg?branch=master[Coverage Status]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work updating the badge.
docs/DeveloperGuide.adoc
Outdated
@@ -864,6 +864,33 @@ Windows, Linux, Unix, OS-X | |||
[[private-contact-detail]] Private contact detail:: | |||
A contact detail that is not meant to be shared with others | |||
|
|||
[[personal-trainer]] Personal trainer:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to be more specific in defining target user profile. Who are they? What they do? What are their problems? What are their current solutions? What your value proposition that might be better than these current solutions?
@@ -17,6 +17,7 @@ | |||
public class AddCommand extends UndoableCommand { | |||
|
|||
public static final String COMMAND_WORD = "add"; | |||
public static final String COMMAND_ALIAS = "a"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the command alias but remember to also update the user guide to match new behavior.
@hypertun @ppalla0325 @wayneong95 @wenhao53 you should think through the product's end behavior and write the entire UG, for all the commands which you would want to implement. Then mark the features as future (v2.0) which you do not intend to implement in the project duration. We should be able to understand what is your product aiming to do from reading the User guide, which as of now is not the case. You should also indicate which features can be expected from which milestones. The PR title should be updated as weeks go by, i.e. now it should be One more thing, remember to enable auto-publishing features for documentations (ReadMe, AboutUs, UG, DG etc...) |
@hypertun @ppalla0325 @wayneong95 @wenhao53 I would want you to mention the following in your Developer guide
|
@erik0704 It was already added into the developer guide on Monday |
@hypertun @ppalla0325 @wayneong95 @wenhao53 Regarding how to documenting your enhancement implementation:
|
…Storage Updated XmlAdaptedAppointment, Added UniqueAppointmentTag Field
Updated documentation
Merge pull request #124 from wenhao53/Enhancements
Updated DG to fix display issues and version number in MainApp
Merge pull request #125 from wenhao53/Enhancements
Included more persons in SampleDataUtil
Updated portfolio links to adoc instead of HTML
…ents Revert "Updated portfolio links to adoc instead of HTML"
Updated Ivan's name
Update from org repo
Updated portfolio links and app title in UGDG
No description provided.