Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5][T11-B2] PrisonBook #78

Open
wants to merge 392 commits into
base: master
Choose a base branch
from

Conversation

zacci
Copy link

@zacci zacci commented Mar 9, 2018

No description provided.

@sarahgoh97
Copy link

Update DeveloperGuide: user stories, use cases, non-functional requirements and glossary
Enhance different parts of the AddressBook:

  • philos22: add Prisoner class
  • zacci: add command aliases
  • sarahgoh97: update status bar

Copy link

@devamanyu devamanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion in the tutorial, user stories, use cases and NFRs have been updated. Overall a good PR.

Issue tracker hasn't been setup yet, and are advised to do so.

Its also nice to see that Travis builds are taken into account.

Please read the minor comments made. Please DO NOT close this PR as we will use it for tracking your milestones!

+
Use case resumes at step 2.
[discrete]
=== Use case: Get the list of prisoners in a certain cell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering of this guide shows an indentation error at this point. Please try to fix that.

. Should work for 32-bit and 64-bit environments
. System should respond within 2 seconds
. Should have different levels of access for users of different ranks.
. Should have a backup copy at all times in case a user accidentally deletes any information.

_{More to be added}_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrase should be removed is the list is exhaustively filled.


By: `Team SE-EDU`      Since: `Jun 2016`      Licence: `MIT`
By: `CS2103-T11-B2`      Since: `Jan 2018`      Licence: `MIT`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on correcting this as most of the teams missed it.

@ashrafabdul
Copy link

@sarahgoh97 @zacci @philos22

Some comments. Please review and work on them

  • About Us : Some images broken. You may also remove John Doe. This should page should reflect your team, individual roles and responsibilities.

  • User Guide : Please indicate feature release by versions. You only mention for v2.0. This needs to contain all the feature you plan to complete and when each feature will be available.

@zacci zacci changed the title [v1.0][T11-B2] PrisonBook [v1.2][T11-B2] PrisonBook Mar 22, 2018
whenzei pushed a commit to whenzei/main that referenced this pull request Mar 27, 2018
* fix merge errors

* Add dummy classes to support import feature

* Add details in JobEntry and SessionData

* more edits

* Add classes to support ImportSession

* Apply SLAP to make methods smaller

* Add ImportSession method to read excel file.

* Add SheetHeaderFields class

* Add SheetWithHeaderFields to extract row and column operations

* Finish ImportSession feature to write to file

* trailing whitespace

* Extract messages in ImportSession as constants. Write dummy ImportAllCommand, with functional support classes.

* Use unmodifiableList for getting lists in sessionData and jobEntry.

* Implement importAll command

* fix modelStub

* fix checkstyle error

* fix checkstyle error

* Rename method addUnreviewedJobEntries to addSheet
sarahgoh97 and others added 3 commits April 15, 2018 23:01
@zacci zacci changed the title [v1.3][T11-B2] PrisonBook [v1.5][T11-B2] PrisonBook Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants