Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5][F12-B3] Media Socializer #88

Open
wants to merge 416 commits into
base: master
Choose a base branch
from

Conversation

shadow2496
Copy link

Copy link

@OuyangDanwen OuyangDanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the UG asap. You should document all features (up to V2.0) in UG in detail. Mark them accordinly, eg. V1.5, V2.0, etc. This is required for the team component last week. Therefore, I have to consider your team component a miss for last week. @shadow2496 @KevinChuangCH @Nethergale In addition, update the AboutUs Page and ContactUS page asap by next tutorial.

https://ci.appveyor.com/project/damithc/addressbook-level4[image:https://ci.appveyor.com/api/projects/status/3boko2x2vr5cc3w2?svg=true[Build status]]
https://coveralls.io/github/se-edu/addressbook-level4?branch=master[image:https://coveralls.io/repos/github/se-edu/addressbook-level4/badge.svg?branch=master[Coverage Status]]
https://www.codacy.com/app/damith/addressbook-level4?utm_source=github.com&utm_medium=referral&utm_content=se-edu/addressbook-level4&utm_campaign=Badge_Grade[image:https://api.codacy.com/project/badge/Grade/fc0b7775cf7f4fdeaf08776f3d8e364a[Codacy Badge]]
https://travis-ci.org/CS2103JAN2018-F12-B3/main[image:https://travis-ci.org/CS2103JAN2018-F12-B3/main.svg?branch=master[Build Status]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@@ -864,6 +959,9 @@ Windows, Linux, Unix, OS-X
[[private-contact-detail]] Private contact detail::
A contact detail that is not meant to be shared with others

[[social-media-platform]] Social media platform::
A platform that makes people distribute information and encourages them to connect with others

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to update the product survey.


*MSS*

1. User requests to apply the filter of <<social-media-platform,a social media platform>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write it in a A-B-A-B format instead of A-A-B. This is required. It should be a forth-back interaction.

@KevinChuangCH
Copy link

@OuyangDanwen
Sorry, the update of AboutUs and part of update of UG was actually done. I forgot to merge them since I thought the tutor has check for them during the tutorial.

@shadow2496 shadow2496 changed the title [v1.0][F12-B3] Media Socializer [v1.2][F12-B3] Media Socializer Mar 21, 2018
Copy link

@OuyangDanwen OuyangDanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UG is generally okay. Make sure it is ready before peer testing. DG needs more work. Please update the diagrams accordingly to meet your design. It is important that you have diagrams to explain your design. It is also good to show them in your individual portfolio. Do not only use plain words. Apply your UML knowledge as far as possible. @shadow2496 @KevinChuangCH @Nethergale

YuanQLLer pushed a commit to YuanQLLer/addressbook-level4 that referenced this pull request Mar 26, 2018
whenzei pushed a commit to whenzei/main that referenced this pull request Mar 28, 2018
@shadow2496 shadow2496 changed the title [v1.2][F12-B3] Media Socializer [v1.3][F12-B3] Media Socializer Mar 30, 2018
Nethergale and others added 29 commits April 13, 2018 23:02
Rename SocialMediaPlatformBuilder to SocialMediaPlatformFactory
Update portfolio and developer guide
Edit build.gradle to output jar with application name
Model: made LoginCommand work limited to Facebook
@shadow2496 shadow2496 changed the title [v1.3][F12-B3] Media Socializer [v1.5][F12-B3] Media Socializer Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants