Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editc: Index error message should have priority over missing fields #6027

Open
nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Open

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 13, 2020

Steps to Reproduce:

  1. Open App
  2. Enter "editc 14" when there is less than 14 contact entries

Expected Behavior: The error message for the invalidness of the index should be prioritized over missing fields.

Actual Behavior: "At least one field to edit must be provided." I understand that this may be a bit contentious, but intuitively it feels like that an obviously wrong index should have priority over other missing fields for this tester.

5.PNG


[original: nus-cs2103-AY2021S1/pe-interim#6023]
@jazerler
Copy link
Contributor

Team's Response

An edit command with a valid index and no fields cannot ever be accepted as a valid command, but an edit command with invalid index and valid fields can be accepted until it attempts to find if the index is valid.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants