Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing Naming Scheme between Person and Contact #6038

Open
nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Open

Confusing Naming Scheme between Person and Contact #6038

nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Assignees
@joshualiangxy
Labels
response.Rejected severity.Medium status.Done team.4 tutorial.CS2103T-W17 type.DocumentationBug

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 13, 2020 •
edited by Lingy12
Loading

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


This should be standardized as one name in the code base as well as the DG to reflect the actual UI name which is Contact.

3333.PNG

[original: nus-cs2103-AY2021S1/pe-interim#6037]
@Lingy12
Copy link

Lingy12 commented Nov 14, 2020 •
edited by joshualiangxy
Loading

Team's Response

Within the code base, it is still the Person class. Within the context of our product, it should be understandable that Person and Contact are actually the same.

Duplicate status (if any):

--

@zhxchd zhxchd mentioned this issue Nov 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshualiangxy joshualiangxy

Labels
response.Rejected severity.Medium status.Done team.4 tutorial.CS2103T-W17 type.DocumentationBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshualiangxy @Lingy12 @nus-pe-bot