Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information can be provided about the find feature #6042

Open
nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Open

More information can be provided about the find feature #6042

nus-pe-bot opened this issue Nov 13, 2020 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 13, 2020

The findc and findj sections in the user guide are generally quite brief and do not really provide much information to a user on how they work. Perhaps it can be described how the find feature will return results as long as a provided keyword is a substring a relevant field.

Also, if I do not provide arguments to a prefix I enter, the find feature will return me all contacts possessing the field corresponding to that prefix I entered. For example, enter findc p/ will give me all contacts with a phone number. It would be good to mention this in the user guide as well.


[original: nus-cs2103-AY2021S1/pe-interim#6041]
@jazerler
Copy link
Contributor

jazerler commented Nov 14, 2020

Team's Response

It is reasonable to expect that every phone number should contain the empty string, hence this behaviour should be expected. Regardless, it is illogical to be searching for a blank phone number and expect it to filter the list in any way.

On the issue of having more information, the command is self-explanatory, in that it searches for the information provided.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants