Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning message when the edited information is the same as before #5873

Open
nus-se-bot opened this issue Nov 12, 2021 · 1 comment
Open

Comments

@nus-se-bot
Copy link

nus-se-bot commented Nov 12, 2021

Steps to reproduce: when the member at index 1 of the displayed list is named "Bernice Yu", and we type command
edit -mem/ -i/1 -n/Bernice Yu

Expected: An error message saying "The field value is not edited / same as before"

Actual: No error message is shown; editing is still allowed

image.png


[original: nus-cs2103-AY2122S1/pe-interim#5872] [original labels: type.FeatureFlaw severity.VeryLow]
@HolmesJJ
Copy link
Contributor

HolmesJJ commented Nov 13, 2021

Team's Response

Thank you for your effort and time. However it is not a bug.

  1. It will not cause any performance problem even if a user just updates the field with the same content. Hence, we believe that a user can definitely update the field with the same content since it will not have any negative effect on the program or cause any security issue. It is also unreasonable to show an "error message" to the user for this.

  2. Excessive verification may even cause unnecessary bugs.

Therefore, we allow ezFoodie to accept edits with same content.

Hope this clarify your doubt.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants