Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catppuccin Frappe theme #984

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add Catppuccin Frappe theme #984

merged 3 commits into from
Nov 27, 2024

Conversation

rikukiix
Copy link
Contributor

One more color palette from catppuccin.

@WindSoilder
Copy link
Contributor

Hi! Thank you for your contribution. Refer to the pr comment: #935 (comment)
I think it's a custom theme and it should belong to https://github.com/nushell/nu_scripts/tree/main/themes/src/custom-nu-themes. Would you please move the theme there and run make.nu to generate screenshot?

@rikukiix
Copy link
Contributor Author

Got it. Thanks for mentioning that.

@rikukiix
Copy link
Contributor Author

Hi! Thank you for your contribution. Refer to the pr comment: #935 (comment) I think it's a custom theme and it should belong to https://github.com/nushell/nu_scripts/tree/main/themes/src/custom-nu-themes. Would you please move the theme there and run make.nu to generate screenshot?

After running make.nu, all the theme .nu files in themes/nu-themes got one more new line at the end of file than original files. I dont know if that is ok or I should manually remove them.

And the themes/src/preview-generate-screenshots.nu cannot run on my Windows system. I have little nu script or pwsh knowledge to cope with that.

Error: nu::parser::variable_not_found

  × Variable not found.
    ╭─[D:\workplace\nu_scripts\themes\src\preview-generate-screenshots.nu:27:17]
 26 │         use .. *
 27 │         source ($name)
    ·                 ──┬──
    ·                   ╰── variable not found.
 28 │         clear
    ╰────

@fdncred
Copy link
Collaborator

fdncred commented Nov 26, 2024

@NotTheDr01ds any ideas about this script? I've ran into the problem before, and you remembered how to run it. I've forgotten.

@NotTheDr01ds
Copy link
Contributor

Let's hold off on adding new screenshot until we get that figured out. Is it okay if we add the theme without the preview in the (hopefully) short-term?

I definitely need to come back to the SVG work and get that over the goal line.

@fdncred fdncred merged commit 4784669 into nushell:main Nov 27, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Nov 27, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants