Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Nix-related files to nushell/integrations #58

Open
kubouch opened this issue Jan 28, 2024 · 5 comments
Open

Move Nix-related files to nushell/integrations #58

kubouch opened this issue Jan 28, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@kubouch
Copy link

kubouch commented Jan 28, 2024

Is your feature request related to a problem? Please describe.

We recently set up a community maintained https://github.com/nushell/integrations to keep package manager and other integration files for Nushell projects there. The intent is to avoid cluttering our repositories with 3rd party tool files that the core team has to maintain.

Describe the solution you'd like

Move Nix-related files to https://github.com/nushell/integrations

Describe alternatives you've considered

Since the core team doesn't actively develop nufmt (yet?), it depends on the active nufmt developers if they want these in and maintain them. But once we scale up the development, we might move them, since that's the direction we've followed in Nushell itself and recently nupm.

@kubouch kubouch added the enhancement New feature or request label Jan 28, 2024
@amtoine
Copy link
Member

amtoine commented Jan 28, 2024

sounds very nice to have everything centralized into once place

@amtoine
Copy link
Member

amtoine commented Jan 28, 2024

i don't know if simply moving flake.nix and flake.lock to a new nufmt/ directory in nushell/integrations would be enough?

@kubouch
Copy link
Author

kubouch commented Jan 28, 2024

I'm thinking a better idea would be to have a directory per package manager. I imagine package managers could reuse some files between projects, or have a top-level Nushell package with nupm/nufmt/... as its sub-packages. So it could look something like

nushell/integrations
+-- apt/
      +-- nufmt/
      +-- nupm/
      +-- nushell/
      +-- common-stuff/
+-- nix/
      +-- nufmt/
      +-- nupm/
      +-- nushell/
      +-- common-stuff/

Note that just copy-pasting the current flake files (the .envrc has some nix stuff in it as well) to nushell/integrations won't work, the flake would need to change to fetch nufmt from GitHub instead of building from local file tree.

@amtoine
Copy link
Member

amtoine commented Jan 28, 2024

yup, all of this makes perfect sense 👌

@AucaCoyan
Copy link
Contributor

Yes! I completely agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants