-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors detected from nushell/nu_scripts #142
Comments
if anyone wants to work on any one of these specific issues, let me know and i can put your name by the item. |
fdncred
pushed a commit
that referenced
this issue
Nov 17, 2024
This PR should fix #98, as well as several easy problems mentioned in #142. I think I should keep each PR focused for better traceability, so the trickier issues related to identifier and parameters are left for later. ## Command * [x] - val_interpolated as the external command head - example: `^$"($cmd)"` ## Redirection * [x] - append ops, example `1 o>> foo` * [x] - values redirection, example `1 + 1 o> foo` * [x] - redirect pipes should be single token, example `cmd1 e>| cmd2` ## Parameters/command args * [x] - spread types ## Misc * [x] - variable as cell_path: `$foo.$bar.$baz`, it turns out `$bar` is treated as string instead. ## Changes made to the existing test cases - `unquoted` node in `decl_use` renamed to `val_string` to align with `stmt_source` - cases that should fail now simply tagged with `:error` since we generally don't care where the error occurs
fdncred
pushed a commit
that referenced
this issue
Nov 18, 2024
This PR fixes those parameter/flag related issues in #142
fdncred
pushed a commit
that referenced
this issue
Nov 19, 2024
This PR fixes most of the remaining issues related to identifiers as reported in #142 . ```nushell # values null 7b nan # commands g++ 7z 7mss truee ``` It's still not perfect, nushell handles special characters like `-, #, ., ()` in identifiers very dynamically. I think this is the time to finally resort to an external scanner for further accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Command
~/test.nu arg1 arg2
^$"($cmd)"
Identifier
g++ foo.cpp
7z
export module foo/
$0
{echo%: foo}
Redirection
1 o>> foo
1 + 1 o> foo
cmd1 e>| cmd2
Parameters/command args
-
should be allowed as short_flag-flag=foo
--flag=name:string@"nu-complete flag"
--flag(-f): list<string@"nu-complete flag">
Misc
$foo.$bar.$baz
echo foo"bar"
The text was updated successfully, but these errors were encountered: