Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result in state for construct_provider! #25

Open
1 task done
lemarier opened this issue Apr 30, 2023 · 0 comments
Open
1 task done

Result in state for construct_provider! #25

lemarier opened this issue Apr 30, 2023 · 0 comments
Labels
enhancement New feature or request mashin_sdk Related to `mashin_sdk`

Comments

@lemarier
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Motivation

Better provider building management

Request

The state builder in construct_provider! should return a Result For better error handling

Solution

mashin/sdk/src/provider.rs

Line 104 in f55b974

let state_fn: fn(::std::sync::Arc<::mashin_sdk::ext::parking_lot::Mutex<::mashin_sdk::ProviderState>>, &Config) = $state_fn;

Are you willing to help with this request?

Yes!
@lemarier lemarier added the enhancement New feature or request label Apr 30, 2023
@lemarier lemarier self-assigned this Apr 30, 2023
@lemarier lemarier changed the title State builder Result in state for construct_provider! Apr 30, 2023
@lemarier lemarier added the mashin_sdk Related to `mashin_sdk` label Apr 30, 2023
@lemarier lemarier added this to mashin Apr 30, 2023
@lemarier lemarier moved this to Todo in mashin Apr 30, 2023
@lemarier lemarier removed their assignment Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mashin_sdk Related to `mashin_sdk`
Projects
mashin
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemarier