This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
ADD: adding azure blob storage support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
| } | ||
|
|
||
| // Upload upload a file to blob | ||
| func (s *Storing) Upload(name string, contentType string, content []byte) (string, error) { |
There was a problem hiding this comment.
two or more consecutive named function parameters share a type, you can omit the type from all but the last
Suggested change
| func (s *Storing) Upload(name string, contentType string, content []byte) (string, error) { | |
| func (s *Storing) Upload(name, contentType string, content []byte) (string, error) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for azure blob storage and also fix the issues regarding s3 loggin information, that were wrong in some parts! Fix #5