Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sub-command regex to support ranges #18

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

wassimk
Copy link
Contributor

@wassimk wassimk commented Jun 14, 2024

I have a personal Neovim plugin that lets me quickly jump from Neovim into GitHub PRs and blames based on commit shas, numbers, or search queries. My first version had a bunch of root-level commands. Then I read your guide, and subcommands are easy to implement now! So I did it! Thanks for writing it. I learned a ton.

My commands use ranges, and I realize the example doesn't support them. Maybe adding them to the example would be nice, even if the Rocks command doesn't use ranges.

With this added regex the sub-commands will auto-complete even when using ranges.
Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

LGTM

@mrcjkb mrcjkb merged commit 78eb7e8 into nvim-neorocks:main Jun 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants